Fixes for reading masks in HEMCO (merge bugfix/masks into HEMCO 3.7.0)

[yantosca]

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Confirm you have reviewed the following documentation

• Contributing guidelines

Describe the update

This brings the bugfix/masks branch (which prevents trying to read a mask from disk if its entry does not end in *.nc* into the 3.7.0 develpment branch.

Expected changes

This brings together a fix implemented by @jimmielin when using HEMCO in MPI environments (GCHP, GEOS, WRF, CESM), as described below:

          ! Because the code only distinguishes between full/partial and zero
          ! coverage, and skips reading the base field if coverage is zero,
          ! this may cause issues with MPI environments in WRF and CESM where
          ! the mask lon1/lat1/lon2/lat2 boundaries are set too small compared
          ! to the mask, and result in the base field being skipped over small
          ! CPU decompositions where it should not have been. The above fix
          ! does not fix the issue where ThisCover == 0, which is the root
          ! cause in WRF and CESM. Thus, always set to partial coverage
          ! (hplin, 8/19/22)

with a bug fix by @yantosca to avoid reading a mask from disk if the filename is -:

          ! If ncFile is passed as the lon1/lat1/lon2/lat2 instead
          ! of netCDF file name, then set ncRead to false, so that
          ! HEMCO won't try to read a file from disk.  Also set the
          ! IsLocTime flag to TRUE.  This should fix Github issue
          ! https://github.com/geoschem/HEMCO/issues/153.
          !  -- Bob Yantosca (12 Jul 2022)
          IF ( INDEX( Lct%Dct%Dta%ncFile, ".nc" ) == 0 ) THEN
             Lct%Dct%Dta%ncRead    = .FALSE.
             Lct%Dct%Dta%IsLocTime = .TRUE.
          ENDIF

Reference(s)

N/A

Related Github Issue(s)

See issue #163

[stale]

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.