Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the string length for reading lines from HEMCO standalone grid #207

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

msulprizio
Copy link
Contributor

Name and Institution (Required)

Name: Melissa Sulprizio
Institution: Harvard/GCST

Confirm you have reviewed the following documentation

Describe the update

In order to run the HEMCO standalone with the 0.25x0.3125 global grid (defined in run/HEMCO_sa_Grid.025x03125.rc), the line length for reading YEDGE and YMID must be increased. Previously, it was LEN=4095 when the length of YEDGE is 5341 and YMID is 4616. To prevent errors when reading the HEMCO standalone grid file and defining the grid in routine Set_Grid, the length of DUM has been increased to 5500.

Related Github Issue(s)

#206

…id file

In order to run the HEMCO standalone with the 0.25x0.3125 global grid
(defined in run/HEMCO_sa_Grid.025x03125.rc), the line length for reading
YEDGE and YMID must be increased. Previously, it was LEN=4095 when the
length of YEDGE is 5341 and YMID is 4616. To prevent errors when reading
the HEMCO standalone grid file and defining the grid in routine Set_Grid,
the length of DUM has been increased to 5500.

This addresses #206.

Signed-off-by: Melissa Sulprizio <[email protected]>
@msulprizio msulprizio added the category: Bug Something isn't working label Apr 14, 2023
@msulprizio msulprizio self-assigned this Apr 14, 2023
@msulprizio msulprizio requested a review from yantosca April 14, 2023 11:40
@yantosca yantosca added the topic: HEMCO Standalone Model Pertaining to the HEMCO standalone label Apr 14, 2023
@yantosca yantosca added this to the 3.7.0 milestone Apr 14, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are simple changes to increase the max length of the string to read input data. Good to merge.

@msulprizio msulprizio merged commit 4de267a into dev/3.7.0 Apr 14, 2023
@msulprizio msulprizio deleted the bugfix/increase-config-line-length branch April 14, 2023 16:08
@msulprizio msulprizio linked an issue Apr 14, 2023 that may be closed by this pull request
4 tasks
@yantosca yantosca linked an issue Jul 19, 2023 that may be closed by this pull request
4 tasks
@yantosca yantosca added category: Bug Fix Fixes a bug that was previously reported and removed category: Bug Something isn't working labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: HEMCO Standalone Model Pertaining to the HEMCO standalone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible bug with HEMCO at 0.25 degree resolution HEMCO standalone crashing for 0.25x0.3125 global grid
2 participants