rename HEMCO_Config.rc.sample to HEMCO_Config.rc #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
added
topic: Configuration Files
yantosca
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Looks good to merge @nicholasbalasus. We can get this into the dev/no-diff-to-benchmark branch, for the upcoming GC 14.2.3 / HEMCO 3.7.2 patch release.
|
All GEOS-Chem Classic integration tests (except TOMAS) passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #f5b5694 Merge branch 'docs/dev' into dev/14.2.2
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 10285010
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2 # <==== TOMAS15 and TOMAS40
Execution tests not yet completed: 0All GEOS-Chem Classic integration tests were zero-diff w/r/t 14.2.2, except TOMAS (failed), APM (parallelization issues) and RRTMG (parallelization issue in diagnostic output). All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
gchp #074494e GEOS-Chem submodule update: Merge PR #2009 fixing links to RTD
GEOS-Chem #382f11dca Merge PR #2040 (Lower GCHP timestep threshold if > C180)
HEMCO #6ab11ea Merge PR #245 (Rename HEMCO_Config.rc.sample to HEMCO_Config.rc)
Number of execution tests: 5
Submitted as SLURM job: 10285450
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GCHP integration tests were also zero-diff w/r/t 14.2.2. |
yantosca
added a commit
that referenced
this pull request
Dec 1, 2023
This is the official release of HEMCO 3.7.2. Updates include: - Add utility scripts to change version numbers before release (PR #242) - Rename HEMCO Config.rc.sample to HEMCO_Config.rc for standalone (PR #245) - Increase string length for netCDF variable name (PR #248) - Turn off emission extensions when EMISSIONS logical is false (PR #250) Signed-off-by: Bob Yantosca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Nick Balasus
Institution: Harvard University
Confirm you have reviewed the following documentation
Describe the update
In
createRunDir.sh, users are given the option to type./HEMCO_Config.rc.sampleif they do not have aHEMCO_Config.rcfile. Currently,HEMCO_Config.rc.sampleis copied directly without changing the name, meaning this code does not run successfully becauseHEMCO_Config.rcdoes not exist.HEMCO/run/createRunDir.sh
Lines 366 to 368 in 00aaf65
To fix this, I rename
HEMCO_Config.rc.sampletoHEMCO_Config.rc. This is consistent with what is done forHEMCO_Diagn.rc.HEMCO/run/createRunDir.sh
Line 310 in 00aaf65
Expected changes
Only to HEMCO standalone run directory creations where the user specifies
./HEMCO_Config.rc.sample.Reference(s)
n/a
Related Github Issue(s)
n/a