Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove month loop in GetIndex2Interp #254

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove month loop in GetIndex2Interp #254

merged 1 commit into from
Jan 9, 2024

Conversation

nicholasbalasus
Copy link
Contributor

Name and Institution (Required)

Name: Nick Balasus
Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

Removes one of the loops in GetIndex2Interp that was used to find the upper bound for time interpolation. The loop that is removed is impacting leaf area index interpolation (see #253).

Expected changes

Met_MODISLAI will be altered in all simulations.

Reference(s)

n/a

Related Github Issue(s)

#253

@yantosca yantosca added topic: Regridding or Interpolation Related to issues with time interpolation or horiziontal/vertical regridding category: Bug Fix Fixes a bug that was previously reported labels Jan 2, 2024
@yantosca yantosca self-assigned this Jan 2, 2024
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. I'll add the CHANGELOG update.

yantosca added a commit that referenced this pull request Jan 2, 2024
CHANGELOG.md
- Add entry describing the fix in PR #254

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor

yantosca commented Jan 2, 2024

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #6417c08 HEMCO submodule update: Merge PR #244 containing fix for IsModelLevel check in CESM and WRF-GC
GEOS-Chem #e4145feec Merge pull request #1522 from branch 'feature/cloud-j' into dev/14.3.0
HEMCO     #c247be4 Added changelog entry for LAI interpolation bug fix

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 14255864
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor

yantosca commented Jan 3, 2024

All GCHP integration tests also passed

==============================================================================
GCHP: Execution Test Results

GCHP      #5692f34 GEOS-Chem submod update: Merge PR #2084 (Fix exe name in int tests)
GEOS-Chem #be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests)
HEMCO     #c247be4 Added changelog entry for LAI interpolation bug fix

Number of execution tests: 5

Submitted as SLURM job: 14331395
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca yantosca changed the base branch from dev/3.8.0 to dev/no-diff-to-benchmark January 3, 2024 16:52
@yantosca yantosca changed the base branch from dev/no-diff-to-benchmark to dev/3.8.0 January 3, 2024 16:52
msulprizio added a commit that referenced this pull request Jan 9, 2024
@msulprizio msulprizio merged commit 861aa5d into geoschem:dev/3.8.0 Jan 9, 2024
1 check passed
@msulprizio msulprizio linked an issue Jan 9, 2024 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a bug that was previously reported topic: Regridding or Interpolation Related to issues with time interpolation or horiziontal/vertical regridding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Interpolation does not pick correct time bounds for LAI
3 participants