-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove month loop in GetIndex2Interp #254
Merged
msulprizio
merged 1 commit into
geoschem:dev/3.8.0
from
nicholasbalasus:bugfix/lai-interpolation
Jan 9, 2024
Merged
Remove month loop in GetIndex2Interp #254
msulprizio
merged 1 commit into
geoschem:dev/3.8.0
from
nicholasbalasus:bugfix/lai-interpolation
Jan 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yantosca
added
topic: Regridding or Interpolation
Related to issues with time interpolation or horiziontal/vertical regridding
category: Bug Fix
Fixes a bug that was previously reported
labels
Jan 2, 2024
yantosca
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge. I'll add the CHANGELOG update.
yantosca
added a commit
that referenced
this pull request
Jan 2, 2024
CHANGELOG.md - Add entry describing the fix in PR #254 Signed-off-by: Bob Yantosca <[email protected]>
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #6417c08 HEMCO submodule update: Merge PR #244 containing fix for IsModelLevel check in CESM and WRF-GC
GEOS-Chem #e4145feec Merge pull request #1522 from branch 'feature/cloud-j' into dev/14.3.0
HEMCO #c247be4 Added changelog entry for LAI interpolation bug fix
Using 24 OpenMP threads
Number of execution tests: 26
Submitted as SLURM job: 14255864
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
All GCHP integration tests also passed ==============================================================================
GCHP: Execution Test Results
GCHP #5692f34 GEOS-Chem submod update: Merge PR #2084 (Fix exe name in int tests)
GEOS-Chem #be203a9d9 Merge PR #2084 (Use rundir to generate executable file name in tests)
HEMCO #c247be4 Added changelog entry for LAI interpolation bug fix
Number of execution tests: 5
Submitted as SLURM job: 14331395
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category: Bug Fix
Fixes a bug that was previously reported
topic: Regridding or Interpolation
Related to issues with time interpolation or horiziontal/vertical regridding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Nick Balasus
Institution: Harvard University
Confirm you have reviewed the following documentation
Describe the update
Removes one of the loops in
GetIndex2Interp
that was used to find the upper bound for time interpolation. The loop that is removed is impacting leaf area index interpolation (see #253).Expected changes
Met_MODISLAI
will be altered in all simulations.Reference(s)
n/a
Related Github Issue(s)
#253