Fix inconsistent pressure units in HEMCO standalone #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CHANGELOG.md - Added a note about fixing the pressure issue in HEMCO standalone Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
topic: HEMCO Standalone Model
src/Core/hco_geotools_mod.F90 - Check if PSFC (surface pressure) is in hPa on the first call to HCO_CalcVertGrid. Use a SAVEd logical flag (DO_SCALE_PSFC) to denote if we need to convert from hPa to Pa. - Add code to convert PSFC from hPa to Pa on each timestep, depending on the value of DO_SCALE_PSFC - Updated comments Signed-off-by: Bob Yantosca <[email protected]>
yantosca
commented
Aug 1, 2024
| IF ( .NOT. FoundPEDGE ) THEN | ||
| !$OMP PARALLEL DO & | ||
| !$OMP DEFAULT( SHARED ) & | ||
| !$OMP PRIVATE( I, J, L ) | ||
| !$OMP PRIVATE( I, J, L ) & | ||
| !$OMP COLLAPSE( 3 ) |
There was a problem hiding this comment.
Collapsing the loop will result in a speedup.
|
Integration tests are running. |
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #6f22240 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #e29a4c928 Merge PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP)
HEMCO #8be6b60 Convert PSFC from hPa -> Pa in HCO_CalcVertGrid
Using 24 OpenMP threads
Number of execution tests: 28
Submitted as SLURM job: 42183358
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t the prior PR #2398 except for
|
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #136fa70 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #e29a4c928 Merge PR #2398 (Pass non-zero Ca2, Mg, and K cations to HETP)
HEMCO #
Number of execution tests: 11
Submitted as SLURM job: 42183723
==============================================================================
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_carbon..................................Execute Simulation....PASS
gchp_merra2_carbon_CH4..............................Execute Simulation....PASS
gchp_merra2_carbon_CO...............................Execute Simulation....PASS
gchp_merra2_carbon_CO2..............................Execute Simulation....PASS
gchp_merra2_carbon_OCS..............................Execute Simulation....PASS
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_fullchem_TOMAS15........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 11
Execution tests failed: 0
Execution tests not yet completed: 0
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%Also, all tests were zero-diff w/r/t PR #2398. |
msulprizio
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Describe the update
This is the companion PR to #277 by @yuanjianz. It fixes the inconsistent pressure unit handling in the HEMCO standalone as described in that issue.
Expected changes
The HEMCO standalone will use 'Pa' for pressure units regardless of input meteorology.
Related Github Issue