Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emission factors for ALK6, C4H6, EBZ, STYR, TMB emissions in GFED and FINN biomass burning #285

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

yantosca
Copy link
Contributor

@yantosca yantosca commented Aug 1, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Describe the update

This is the companion PR to geoschem/geos-chem#2390. This adds emission factors for new the species (from @kelvinb) in the chemistry updates from Travis et al 2023 (see PR geoschem/geos-chem#2318).

Expected changes

  • Need more information

Reference(s)

Related Github Issue

src/Extensions/hcox_finn_mod.F90
src/Extensions/hcox_gfed_include_gfed4.H
- Updated with new emission factors (cf Kelvin Bates) for new species
  introduced in K. Travis et al 2023 (see PR #2318)

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added category: Feature Request New feature or request topic: HEMCO Extensions Pertaining to HEMCO extensions labels Aug 1, 2024
@yantosca yantosca added this to the 3.10.0 milestone Aug 1, 2024
@yantosca yantosca self-assigned this Aug 1, 2024
@yantosca yantosca changed the base branch from main to dev/3.10.0 August 1, 2024 21:10
@yantosca
Copy link
Contributor Author

yantosca commented Aug 5, 2024

Heads up @msulprizio @lizziel @yuanjianz @yidant: This PR will affect biomass burning emissions, as there are several new species being added. These species will have to be added to the offline emissions. In the meantime, I think we would have to activate GFED4 by default to provide emissions for these species even when using the current offline emissions.

src/Extensions/hcox_gfed_include_gfed4.H
- Species ACR should use index #41 but was assigned with index #36.
  This caused RCHO to be overwritten, causing an indexing error.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca
Copy link
Contributor Author

yantosca commented Aug 6, 2024

All GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #136fa70 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #38b6d1801 Update HEMCO_Config.rc for CESM with Kelvin Bates emissions updates
HEMCO     #

Number of execution tests: 11

Submitted as SLURM job: 42874275
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

@yantosca
Copy link
Contributor Author

yantosca commented Aug 6, 2024

All GEOS-Chem Classic integration tests passed:

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #6f22240 GEOS-Chem submod update: Merge PR #2398 (Uncomment cations for HETP)
GEOS-Chem #38b6d1801 Update HEMCO_Config.rc for CESM with Kelvin Bates emissions updates
HEMCO     #3076296 Species ACR should use index #41 in hcox_gfed_include_gfed4.H

Using 24 OpenMP threads
Number of execution tests: 28

Submitted as SLURM job: 42874229
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Copy link
Contributor

@msulprizio msulprizio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This update looks good to merge.

Note that we should generate an updated GFED climatology file that includes these species. I have created a feature request at geoschem/geos-chem#2415.

Copy link
Contributor Author

yantosca commented Aug 7, 2024

Thanks @msulprizio!

@ktravis213
Copy link

ktravis213 commented Aug 14, 2024

Is ACR included now as an emitted GFED species?

@yantosca
Copy link
Contributor Author

yantosca commented Aug 15, 2024

@ktravis213 @kelvinhb: Yes, ACR is now a GFED species. See the config file:

111     GFED                   : on  NO/CO/ALK4/ACET/MEK/ALD2/PRPE/C2H2/C2H4/C3H8/CH2O/C2H6/SO2/NH3/BCPO/BCPI/OCPO/OCPI/POG1/POG2/MTPA/BENZ/TOLU/XYLE/NAP/EOH/MOH/SOAP/FURA/PHEN/MVK/ISOP/ACTA/MGLY/GLYX/RCHO/HCOOH/ACR/STYR/C4H6

yantosca added a commit that referenced this pull request Aug 20, 2024
CHANGELOG.md
- Moved the note about "Added emission factors..." out of the 3.9.3
  section and into the Unreleased section.  This was done automatically
  during the merge.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca merged commit 1c6356d into dev/3.10.0 Aug 20, 2024
@yantosca yantosca deleted the feature/alk6-c4h6-ebz-styr-tmb-emissions branch August 20, 2024 15:50
@yantosca
Copy link
Contributor Author

This PR was merged at the same time as GEOS-Chem PR geoschem/geos-chem#2318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request topic: HEMCO Extensions Pertaining to HEMCO extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emissions of new species (ALK6, C4H6, EBZ, STYR, TMB) from fires and anthropogenic emission
3 participants