Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update incorrect EDGARv7 entries in HEMCO_Config.rc and ExtData.rc for the carbon, CH4, and tagCH4 simulations #2115

Closed
yantosca opened this issue Jan 11, 2024 · 5 comments · Fixed by #1992
Assignees
Labels
category: Bug Something isn't working topic: Configuration Files Related to GEOS-Chem configuration files topic: Emissions Related to emissions inventories used in GEOS-Chem topic: HEMCO Submodule Related to HEMCO

Comments

@yantosca
Copy link
Contributor

yantosca commented Jan 11, 2024

Name and Institution (Required)

Name: Bob Yantosca
Institution: Harvard + GCST

Description of your issue or question

In the CH4 and carbon simulations, the out-of-the-box HEMCO_Config.rc file has these entries to read oil production (PRO_OIL), gas production (PRO_GAS), and coal production (PRO_COAL) emissions.

## Oil ###
#0 EDGAR7_CH4_OIL__1B2a          $ROOT/CH4/v2023-04/EDGARv7/$YYYY/v7.0_FT2021_CH4_$YYYY_PRO_OIL.0.1x0.1.nc          emi_ch4 2010-2021/1-12/1/0 C xy kg/m2/s CH4 732 1 1
0 EDGAR7_CH4_OIL__1B2a          $ROOT/CH4/v2023-04/EDGARv7/$YYYY/v7.0_FT2021_CH4_$YYYY_PRO.0.1x0.1.nc              emi_ch4 2010-2021/1-12/1/0 C xy kg/m2/s CH4 732 1 1
...

### Gas ###
0 EDGAR7_CH4_OIL__1B2c          $ROOT/CH4/v2023-04/EDGARv7/$YYYY/v7.0_FT2021_CH4_$YYYY_PRO_GAS.0.1x0.1.nc          emi_ch4 2010-2021/1-12/1/0 C xy kg/m2/s CH4 731 2 1

### Coal ###
0 EDGAR7_CH4_COAL__1B1a         $ROOT/CH4/v2023-04/EDGARv7/$YYYY/v7.0_FT2021_CH4_$YYYY_PRO_COAL.0.1x0.1.nc         emi_ch4 2010-2021/1-12/1/0 C xy kg/m2/s CH4 730 3 1

But in the EDGARv7 data directory, there are no PRO_OIL, PRO_GAS, PRO_COAL sectorial emissions files, just PRO:

v7.0_FT2021_CH4_2019_AGS.0.1x0.1.nc
v7.0_FT2021_CH4_2019_AWB.0.1x0.1.nc
v7.0_FT2021_CH4_2019_CHE.0.1x0.1.nc
v7.0_FT2021_CH4_2019_ENE.0.1x0.1.nc
v7.0_FT2021_CH4_2019_ENF.0.1x0.1.nc
v7.0_FT2021_CH4_2019_FFF.0.1x0.1.nc
v7.0_FT2021_CH4_2019_IND.0.1x0.1.nc
v7.0_FT2021_CH4_2019_IRO.0.1x0.1.nc
v7.0_FT2021_CH4_2019_MNM.0.1x0.1.nc
v7.0_FT2021_CH4_2019_PRO.0.1x0.1.nc       <=== HERE
v7.0_FT2021_CH4_2019_RCO.0.1x0.1.nc
v7.0_FT2021_CH4_2019_REF_TRF.0.1x0.1.nc
v7.0_FT2021_CH4_2019_SWD_INC.0.1x0.1.nc
v7.0_FT2021_CH4_2019_SWD_LDF.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TNR_Aviation_CDS.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TNR_Aviation_CRS.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TNR_Aviation_LTO.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TNR_Other.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TNR_Ship.0.1x0.1.nc
v7.0_FT2021_CH4_2019_TRO_noRES.0.1x0.1.nc
v7.0_FT2021_CH4_2019_WWT.0.1x0.1.nc

As it turns out the entries mentioned in HEMCO_Config above are superseded by GFEI emissions, so even though the PRO_OIL, PRO_GAS, PRO_COAL files do not exist in EDGARv7, HEMCO won't try to read them.

However, the ExtData.rc.carbon template still has corresponding entries:

# --- EDGAR v7.0 ---
EDGAR7_CH4_OIL__1B2a          kg/m2/s N Y F%y4-%m2-01T00:00:00  none none  emi_ch4  ./HcoDir/CH4/v2023-04/EDGARv7/%y4/v7.0_FT2021_CH4_%y4_PRO_OIL.0.1x0.1.nc
EDGAR7_CH4_OIL__1B2c          kg/m2/s N Y F%y4-%m2-01T00:00:00  none none  emi_ch4  ./HcoDir/CH4/v2023-04/EDGARv7/%y4/v7.0_FT2021_CH4_%y4_PRO_GAS.0.1x0.1.nc
EDGAR7_CH4_COAL__1B1a         kg/m2/s N Y F%y4-%m2-01T00:00:00  none none  emi_ch4  ./HcoDir/CH4/v2023-04/EDGARv7/%y4/v7.0_FT2021_CH4_%y4_PRO_COAL.0.1x0.1.nc

and because MAPL cannot find these files, the GCHP carbon simulation crashes.

Action items:

  • Update EDGAR v7 entries in HEMCO_Config.rc template files.
  • Update EDGARv7 entries in the ExtData.rc.carbon template file.

Tagging @msulprizio @laestrada (as this affects the IMI as well).

@yantosca yantosca added category: Bug Something isn't working topic: HEMCO Submodule Related to HEMCO topic: Configuration Files Related to GEOS-Chem configuration files specialty simulations labels Jan 11, 2024
@yantosca yantosca self-assigned this Jan 11, 2024
@yantosca
Copy link
Contributor Author

yantosca commented Jan 11, 2024

I should note that this is only an error for the GCHP carbon simulation. But if users attempt to disable GFEI emissions, then GCClassic simulations also will stop with an error.

yantosca added a commit that referenced this issue Jan 12, 2024
This commit applies fixes for the problem described in #2115

run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.carbon
run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.CH4
run/GCHP/HEMCO_Config.rc.templates/HEMCO_Config.rc.CH4
run/GCHP/ExtData.rc.templates/ExtData.rc.carbon
- Remove EDGAR7_CH4_OIL__1B2a, EDGAR7_CH4_OIL__1B2c, and
  EDGAR7_CH4_COAL__1B1a.  These entries read from files which do
  not exist in the EDGARv7 inventory.
- Add entry for EDGAR7_CH4_OILGASCOAL__1B1_1B2, which is the replacement
  for the previous entries.
- NOTE: Normally, these entries are superseded by GFEI, which has
  a higher hierarchy.  But these modifications are necessary if a user
  should ever disable GFEI emissions.

run/GCClassic/HEMCO_Config.rc.templates/HEMCO_Config.rc.tagCH4
- I wasn't sure how to update these entries, so I put a comment.
  Will get to this later.

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca linked a pull request Jan 12, 2024 that will close this issue
1 task
@yantosca
Copy link
Contributor Author

Note: I have pushed a fix for this issue to PR #1992.

Copy link

stale bot commented Mar 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. If there are no updates within 7 days it will be closed. You can add the "never stale" tag to prevent the Stale bot from closing this issue.

@stale stale bot added the stale No recent activity on this issue label Mar 13, 2024
@yantosca
Copy link
Contributor Author

This may be a moot point since we will soon add EDGARv8 emissions.

@stale stale bot removed the stale No recent activity on this issue label Mar 13, 2024
@yantosca yantosca added topic: Emissions Related to emissions inventories used in GEOS-Chem and removed topic: Carbon Gas Simulations labels Mar 28, 2024
@yantosca
Copy link
Contributor Author

EDGARv8 has now been added into the GEOS-Chem "no-diff-to-benchmark" development stream. We can now close out this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Configuration Files Related to GEOS-Chem configuration files topic: Emissions Related to emissions inventories used in GEOS-Chem topic: HEMCO Submodule Related to HEMCO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant