-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for Prod/Loss diagnostics for Hg simulation -- Closes #1284, #1285 #1356
Conversation
These updates address the issues raised in geoschem/geos-chem #1284 Headers/diaglist_mod.F90 - Added IsHg and IsCarbonCycle module variables. (The IsCarbonCycle is future-proofing us for 14.1.0, when that mechanism will be added.) Headers/state_diag_mod.F90 - PROD and LOSS for simulations with KPP are now assigned units of molec cm-3 s-1. PROD and LOSS for other specialty simulations are assigned units of kg s-1 (until we bring these into KPP). GeosCore/mercury_mod.F90 - Updated loops that store in to State_Diag%Prod, following suggestion by Ari Feinberg KPP/Hg/Hg.kpp - Added prod families PHg0, PHg2, PHg2Br, PHg2OH, PHg2Cl to Hg.kpp run/shared/species_database_hg.yml - Added entries for PHg0, PHg2Br, PHg2OH, PHg2_Br, PHg2Cl KPP/Hg/gckpp* - Rebuilt with KPP 2.5.0 Signed-off-by: Bob Yantosca <[email protected]>
Now that the Hg simulation has several defined production families, we have added the ProdLoss diagnostic with the 'Prod_?PRD?' wildcard. Signed-off-by: Bob Yantosca <[email protected]>
An .or. statement was missing a trailing "." character. Now fixed. Signed-off-by: Bob Yantosca <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Thanks @Jourdan-He, I'll merge it into patch/14.0.1. |
GEOS-Chem Classic integration tests all passed except for the CO2 simulation: Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 47
Execution tests failed: 1
Execution tests not yet completed: 0 The error in the CO2 simulation was tracked down to an incorrect entry in |
Hi @yantosca @msulprizio - I'm trying to get the version of GCClassic with all of these Hg simulation fixes. I can't seem to figure out which version this is or what I need to pull. I've cloned 14.0.0-rc3 (I think? Whatever the current main version is). I looked for a branch called patch/14.0.1 or feature/HgFamilies but I couldn't find either of these. Is there a quick and easy way to get a version with all the Hg updates? Thanks! |
Hi @jennyfisher, you can take the dev branch and I think that will have the fixes. We are very close to releasing 14.0.0 (once the benchmarks are approved). |
Thanks @yantosca - I have pulled the dev branch and want to double-check a few things with you, @arifein, and @viral211.
Thanks! |
Hi @jennyfisher, regarding 1.: It worked for me to run v14 with these lines deleted from HEMCO_Config.rc, so I would also be on board with this. |
@jennyfisher @arifein: We are awaiting the 14.0.0 10 year benchmark and would use those oxidant fields. We might have those available before 14.1.0 ships. I can change it to the 13.0.0 oxidant fields for now. I can also make sure that the HEMCO_Config.rc.Hg template file is updated accordingly. We are a bit stretched thin right now due to circumstances beyond our control. Thanks for your patience as we sort this out. |
Thanks both. In this case, sounds like we should remove the extra lines from HEMCO_Config.rc (point 1 but leave all else as is for now. Would be interested in opinion of @viral211 on point 3. Bob - no rush, and the 13.0.0 fields are the ones in use now so I don't think you need to change that one until the 10-year benchmark is complete. Thanks! |
@jennyfisher @arifein @yantosca: The Hg2 gas-particle partitioning no longer uses the AERO_* fields; the aerosol fields are included in the GLOBAL_* fields. These fields can also be removed from HEMCO_Config.rc |
This should be all done on PR #1367 now. |
This is the corresponding PR to issue #1284. It adds several minor fixes to the Hg added by @arifein, namely:
GeosCore/mercury_mod.F90
Hg.kpp
andspecies_database_hg.yml
molec cm-3 s-1
for all KPP-based simulationsrun/GCClassic/HISTORY.rc.templates/HISTORY.rc.Hg
Also note: I have updated default Hg restart file so that it now contains the PHg* species. You can download the updated file from: http://ftp.as.harvard.edu/gcgrid/data/ExtData/GEOSCHEM_RESTARTS/v2021-12/GEOSChem.Restart.Hg.20190101_0000z.nc4. This will let you start a simulation without having to change the time cycle flag for
SPC_
fromEFYO
toEY
inHEMCO_Config.rc
.Also tagging @viral211 @lfreese @hmhorow