Add correct TransportTracers species names to GCHP HISTORY.rc.TransportTracers template #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run/GCHP/HISTORY.rc.templates/HISTORY.rc.TransportTracers - Replace old species names with the updated species names from the 14.2.0-alpha.15 update. This was causing integration tests to fail (see geoschem/HEMCO PR #218). Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
category: Bug
1 task
CHANGELOG.md - Added note about fixing the species names in the GCHP HISTORY.rc.TransportTracers template file. Signed-off-by: Bob Yantosca <[email protected]>
The HEMCO_Config.rc and HEMCO_Diagn.rc files for both GCClassic and GCHP still used the old TransportTracer species names. They have now been updated to ensure emissions are properly saved out. Other fixes in this commit include: - Removing obsolete HTAP emissions entries from HEMCO_Config.rc - Removing Emis* entries from HISTORY.rc.TransportTracers for species that do not have emissions - Removing edits to CHANGELOG.md from previous commit since these bugs were introduced in 14.2.0. Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
Signed-off-by: Melissa Sulprizio <[email protected]>
Updates in this commit allow GCHP to run to completion if using the out-of-the-box transport tracer simulation. This includes no longer requiring all species to be present in the restart file as well as a few bug fixes in config file ExtData.rc. Signed-off-by: Lizzie Lundgren <[email protected]>
msulprizio
approved these changes
Jun 26, 2023
|
All GCClassic (except TOMAS) and GCHP integration tests are passing for this pull request. Good to merge. |
1 task
Closed
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR to #1839. The GCHP
HISTORY.rc.TransportTracersfile had old names for the TransportTracers species and not the new names as of the 14.2.0-alpha.15 update. We have now updated theHISTORY.rc.TransportTracersfile to contain the new TransportTracers species names. This should fix the problem noted in https://hExpected changes
This will only affect the GCHP TransportTracers simulations. It should fix failing integration tests and TransportTracers simulations.
This PR can go into a patch version (such as the upcoming 14.2.1).
Reference(s)
N/A
Related Github Issue(s)
Closes #1839; Fixes geoschem/HEMCO#218