Bug fixes for GEOS-only runs #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lizzie Lundgren <[email protected]>
msulprizio
added
the
category: Interface to External Model
msulprizio
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
@lizziel Could you update CHANGELOG.md? Otherwise looks good to merge.
|
These fixes shouldn't need to be in the changelog since the bugs were introduced during 14.2.0 development. |
|
@lizziel OK. Sounds good. Thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Lizzie Lundgren (Harvard) and Viral Shah (GMAO)
Confirm you have reviewed the following documentation
Describe the update
This PR includes two fixes for GEOS related to the restructuring of photolysis in the 14.2 development branch.
Expected changes
This update is zero diff for GCHP and GC-Classic.
Related Github Issue(s) and PRs
No issues. These fixes do not apply to any existing release.
Somewhat related HEMCO PR here, since HEMCO 3.7.0 is meant to be used with GEOS-Chem 14.2.0: geoschem/HEMCO#219