Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard format for AEIC 2019 monthly climatology in ExtData.rc #1876

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Jul 13, 2023

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

This PR changes the ExtData.rc specification for AEIC 2019 monthly climatology files. The standard format used for monthly climatology in ExtData.rc uses the clim flag Y and read frequency in format F{year}-%m2-01T00:00:00. The previous specification used clim year (2019) for the climatology flag and included tokens for year, month, and day for read frequency. The old method works but it would be good to use the standard format for consistency and to avoid confusion during the migration from the ExtData.rc file to the ExtData.yml file when we switch to MAPL 3.

Expected changes

This is a zero diff update for GCHP since the old and new formats give identical results.

Reference(s)

none

Related Github Issue(s)

none

@lizziel lizziel added the topic: Configuration Files Related to GEOS-Chem configuration files label Jul 13, 2023
@lizziel lizziel added this to the 14.2.1 milestone Jul 13, 2023
@lizziel lizziel requested a review from yantosca July 13, 2023 11:50
@lizziel lizziel self-assigned this Jul 13, 2023
The standard format used for monthly climatology in ExtData.rc sets
the clim flag to Y and the read frequency to F{year}-%m2-01T00:00:00.
The previous specification using clim year for the climatology flag and
including tokens for year, month, and day for read frequency works but
it would be good to use the standard format for consistency and to avoid
confusion during the migration from the rc file to the yaml file.

This is a zero diff update for GCHP since the old and new formats give
identical results.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel lizziel force-pushed the bugfix/use_standard_format_for_aeic19_monthly_clim_in_gchp_extdata branch from 106fdf1 to 7c24d9a Compare July 13, 2023 11:54
@yantosca yantosca changed the title Use standard format for AEIC 2019 monthly climatologu in ExtData.rc Use standard format for AEIC 2019 monthly climatology in ExtData.rc Jul 13, 2023
@yantosca yantosca added topic: GCHP Related to GCHP only no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations labels Jul 13, 2023
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge. Thanks @lizziel!

@yantosca
Copy link
Contributor

After merging on top of PR #1682, all GCHP integration tests passed

==============================================================================
GCHP: Execution Test Results

GCClassic #d955ac7 GEOS-Chem submod update: Merge PR #1682 (Fix GCClassic parallel errors)
GEOS-Chem #f9d697f18 Merge PR #1876 (Use standard format for AEIC monthly clim in ExtData.rc)
HEMCO     #bb3b465 Merge PR #218 (Remove redundant code in hco_extlist_mod.F90)

Number of execution tests: 5

Submitted as SLURM job: 62323606
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all GCHP integration tests were zero-diff w/r/t PR #1682:

Checking gchp_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_RRTMG
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca
Copy link
Contributor

After merging on top of #1682, all GEOS-Chem Classic integration tests passed (except for TOMAS, which is a known issue that will be fixed later):

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #3eb17f1 GEOS-Chem submod update: Merge PR #1682 (Fix GCClassic parallel errors)
GEOS-Chem #f9d697f18 Merge PR #1876 (Use standard format for AEIC monthly clim in ExtData.rc)
HEMCO     #bb3b465 Merge PR #218 (Remove redundant code in hco_extlist_mod.F90)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 62323462
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....FAIL
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....FAIL
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 24
Execution tests failed: 2
Execution tests not yet completed: 0

Furthermore, most integration tests were identical to PR #1682 (exceptions being APM and TOMAS, which have known issues that will be fixed later, and RRTMG, which has a parallelization error in as described in #1869).

Checking gc_05x0625_NA_47L_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_05x0625_NA_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS15
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS40
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_aerosol
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_carbon
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CO2
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_aciduptake
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_APM
   -> 2 differences found in OutputDir
      * GCC_14.2.1_r9/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
        GCC_14.2.1_r10/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.Metrics.20190701_0000z.nc4 
      * GCC_14.2.1_r9/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
        GCC_14.2.1_r10/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
   -> 1 difference found in Restarts
      * GCC_14.2.1_r9/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 
        GCC_14.2.1_r10/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 

Checking gc_4x5_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA_SVPOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_marinePOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_RRTMG
   -> 1 difference found in OutputDir
      * GCC_14.2.1_r9/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
        GCC_14.2.1_r10/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
   -> No differences in Restarts

Checking gc_4x5_merra2_Hg
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_metals
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_POPs_BaP
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCO
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca yantosca merged commit f9d697f into dev/14.2.1 Jul 13, 2023
@yantosca yantosca deleted the bugfix/use_standard_format_for_aeic19_monthly_clim_in_gchp_extdata branch July 13, 2023 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants