Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new GCHP config file for ESMF logging #1879

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Add new GCHP config file for ESMF logging #1879

merged 1 commit into from
Jul 18, 2023

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Jul 17, 2023

Name and Institution (Required)

Name: Lizzie lundgren
Institution: Harvard University

Confirm you have reviewed the following documentation

Describe the update

This update goes along with an update developed by Matt Thompson (NASA GMAO) to read ESMF logging mode from log file at run-time. Previously the ESMF logging mode was hard-coded in the GCHP main program in src/GCHPctm.F90. Changing it required recompiling the model. With this update the logging option is instead specified in new config file ESMF.rc in all GCHP run directories and can be changed at run-time. The new config file details what options are available to use.

Expected changes

There is a new config file in GCHP run directories called ESMF.rc. By default a set of ESMF log files will no longer be created if an ESMF error is encountered.

Reference(s)

None

Related Github Issue(s)

GEOS-ESM/MAPL#2133
geoschem/GCHP#304

Related PRs that must be merged at the same time

geoschem/MAPL#29
geoschem/GCHP#330

@lizziel lizziel added topic: GCHP Related to GCHP only topic: Configuration Files Related to GEOS-Chem configuration files labels Jul 17, 2023
@lizziel lizziel added this to the 14.2.1 milestone Jul 17, 2023
@lizziel lizziel requested a review from yantosca July 17, 2023 20:26
@lizziel lizziel self-assigned this Jul 17, 2023
@lizziel lizziel force-pushed the feature/add_GCHP_config_file_for_ESMF_logging branch from 9081c95 to fbe9ac8 Compare July 17, 2023 20:28
This was referenced Jul 17, 2023
Merged
Merged
@lizziel
Add GCHP config file for ESMF logging; turn off ESMF logging by default
067b1f8 
This update has an accompanying update in MAPL to read config file ESMF.rc
to retrieve the setting for ESMF_LogKind. Previously this was set at
compilation time in GCHP and was hard-coded to write an ESMF log file
for each thread upon error. There is currently a benign ESMF error
triggered sometimes when monthly diagnostics are enabled, and that is the
motivation for turning off ESMF logging by default, at least temporarily.

Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel lizziel force-pushed the feature/add_GCHP_config_file_for_ESMF_logging branch from fbe9ac8 to 067b1f8 Compare July 17, 2023 20:47
yantosca
yantosca approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge @lizziel. Thanks!

@yantosca yantosca added the no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations label Jul 17, 2023
@yantosca
Copy link
Contributor

After merging on top of geoschem/HEMCO PR #226, all GCHP integration tests were identical:

==============================================================================
GCHP: Execution Test Results

GCClassic #5994b33 Merge PR #330 (Set ESMF logging option at run-time via config file)
GEOS-Chem #2fd200295 Merge PR #1879 (Add new GCHP config file for ESMF logging)
HEMCO     #725972f PR #226 post-merge fixes: Update CHANGELOG.md

Number of execution tests: 5

Submitted as SLURM job: 63248042
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gchp_merra2_fullchem................................Execute Simulation....PASS
gchp_merra2_fullchem_benchmark......................Execute Simulation....PASS
gchp_merra2_fullchem_RRTMG..........................Execute Simulation....PASS
gchp_merra2_tagO3...................................Execute Simulation....PASS
gchp_merra2_TransportTracers........................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 5
Execution tests failed: 0
Execution tests not yet completed: 0

%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Furthermore, all integration tests were zero-diff w/r/tgeoschem/HEMCO PR #226:

Checking gchp_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_fullchem_RRTMG
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gchp_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca
Copy link
Contributor

After merging on top of geoschem/HEMCO PR #226, all GEOS-Chem Classic integration tests passed (except for TOMAS which is a known issue):

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #2773dc8 GEOS-Chem submod updates: Set ESMF logging mode at run-time
GEOS-Chem #2fd200295 Merge PR #1879 (Add new GCHP config file for ESMF logging)
HEMCO     #725972f PR #226 post-merge fixes: Update CHANGELOG.md

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 63248072
==============================================================================
 
Execution tests:
------------------------------------------------------------------------------
gc_05x0625_NA_47L_merra2_CH4........................Execute Simulation....PASS
gc_05x0625_NA_47L_merra2_fullchem...................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem..........................Execute Simulation....PASS
gc_4x5_47L_merra2_fullchem_TOMAS15..................Execute Simulation....FAIL
gc_4x5_47L_merra2_fullchem_TOMAS40..................Execute Simulation....FAIL
gc_4x5_merra2_aerosol...............................Execute Simulation....PASS
gc_4x5_merra2_carbon................................Execute Simulation....PASS
gc_4x5_merra2_CH4...................................Execute Simulation....PASS
gc_4x5_merra2_CO2...................................Execute Simulation....PASS
gc_4x5_merra2_fullchem..............................Execute Simulation....PASS
gc_4x5_merra2_fullchem_aciduptake...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_APM..........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_benchmark....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA...................Execute Simulation....PASS
gc_4x5_merra2_fullchem_complexSOA_SVPOA.............Execute Simulation....PASS
gc_4x5_merra2_fullchem_LuoWd........................Execute Simulation....PASS
gc_4x5_merra2_fullchem_marinePOA....................Execute Simulation....PASS
gc_4x5_merra2_fullchem_RRTMG........................Execute Simulation....PASS
gc_4x5_merra2_Hg....................................Execute Simulation....PASS
gc_4x5_merra2_metals................................Execute Simulation....PASS
gc_4x5_merra2_POPs_BaP..............................Execute Simulation....PASS
gc_4x5_merra2_tagCH4................................Execute Simulation....PASS
gc_4x5_merra2_tagCO.................................Execute Simulation....PASS
gc_4x5_merra2_tagO3.................................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers......................Execute Simulation....PASS
gc_4x5_merra2_TransportTracers_LuoWd................Execute Simulation....PASS
 
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 24
Execution tests failed: 2
Execution tests not yet completed: 0

Furthermore, all integration tests were zero-diff w/r/thttps://github.com/geoschem/HEMCO/pull/226, with the following exceptions:

Checking gc_05x0625_NA_47L_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_05x0625_NA_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS15
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_47L_merra2_fullchem_TOMAS40
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_aerosol
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_carbon
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_CO2
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_aciduptake
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_APM
   -> 1 difference found in OutputDir
      * GCC_14.2.1_r11/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
        GCC_14.2.1_r12/rundirs/gc_4x5_merra2_fullchem_APM/OutputDir/GEOSChem.SpeciesConc.20190701_0000z.nc4 
   -> 1 difference found in Restarts
      * GCC_14.2.1_r11/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 
        GCC_14.2.1_r12/rundirs/gc_4x5_merra2_fullchem_APM/Restarts/GEOSChem.Restart.20190701_0100z.nc4 

Checking gc_4x5_merra2_fullchem_benchmark
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_complexSOA_SVPOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_marinePOA
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_fullchem_RRTMG
   -> 1 difference found in OutputDir
      * GCC_14.2.1_r11/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
        GCC_14.2.1_r12/rundirs/gc_4x5_merra2_fullchem_RRTMG/OutputDir/GEOSChem.RRTMG.20190701_0000z.nc4 
   -> No differences in Restarts

Checking gc_4x5_merra2_Hg
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_metals
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_POPs_BaP
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCH4
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagCO
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_tagO3
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers
   -> No differences in OutputDir
   -> No differences in Restarts

Checking gc_4x5_merra2_TransportTracers_LuoWd
   -> No differences in OutputDir
   -> No differences in Restarts

@yantosca yantosca merged commit 2fd2002 into dev/14.2.1 Jul 18, 2023
@yantosca yantosca deleted the feature/add_GCHP_config_file_for_ESMF_logging branch July 18, 2023 16:41
This was referenced Jul 19, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yantosca yantosca yantosca approved these changes

Assignees

@lizziel lizziel

Labels
no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: Configuration Files Related to GEOS-Chem configuration files topic: GCHP Related to GCHP only
Projects
None yet
Milestone
14.2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lizziel @yantosca