Add fixes for transport tracers simulation #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transport tracer species aoa*, nh*, St80_25, and StOX did not have molecular weights defined because they're not traditional chemical species. This causes issues with unit conversions in the code and results in negative and/or zero SpeciesConc output. To avoid this, we define MW_g: 1.0 for those species. Signed-off-by: Melissa Sulprizio <[email protected]>
1. Move initialization of mask arrays into loop over species. 2. Make sure to do calculations for maintaining the mixing ratio only in the defined region (where Mask is 1) 3. Fix typo in the logic for determining masks of latitude zones. Signed-off-by: Melissa Sulprizio <[email protected]>
The stOX tracer is defined in GMAO's TR_GridComp but is not commonly utilized and isn't needed in GEOS-Chem. It is removed here to avoid confusion. The fields needed for stOX (GLOBAL_O3 and O3_LOSS) are also removed from tracer_mod.F90 and TransportTracer configuration files. Signed-off-by: Melissa Sulprizio <[email protected]>
Instead of multiplying the source or sink application by the Mask array, the code now checks if Mask > 0 before applying the source or sink. Multiplying by the Mask array may have inadvertently set species concentrations to zero instead of not implying the source or sink. Signed-off-by: Melissa Sulprizio <[email protected]>
The Budget diagnostics collection is now needed for TransportTracer benchmarking. It is now disabled by default to avoid saving out unnecessary data. Signed-off-by: Melissa Sulprizio <[email protected]>
lizziel
approved these changes
Jul 27, 2023
|
All GCClassic and GCHP integration tests for this update have passed. |
yantosca
added
category: Bug Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Confirm you have reviewed the following documentation
Describe the update
This pull request fixes several remaining issues in the transport tracers simulation following #1816. These fixes primarily involve proper calculation and application of masks for applying sources and sinks to latitude zones and vertical regions. An additional fix that was also addressed in the dev/14.2.1 branch is to define MW_g: 1.0 for species with no current molecular weight defined to avoid negative or zero concentrations for those species.
Expected changes
These updates only impact the TransportTracers simulation and will change concentrations of the aoa*, st80_25, and e90(* species.