Fix to address GCClassic failure to integrate with TOMAS when using dev/tomas branch #1959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Betty Croft
Institution: Washington University in St. Louis
Describe the update
This fix addresses that portion of issue #1741 connected with the failure of GCClassic integration when using dev/tomas. This is a correction to HISTORY.rc.fullchem used by GCClassic in the dev/tomas branch. The previous version of this template file had produced a HISTORY.rc file that was erroneous for the Tomas collection, causing failure of GCClassic integrations. A second pull request will address that portion of issue #1741 related to GCHP.
GCClassic based on dev/tomas branch is expected to integrate now for both TOMAS15 and TOMAS40 options.
Note that this update makes the Tomas diagnostic collection complete for TOMAS15. However for TOMAS40, there will only be an output the first 15 bins. I would welcome advice on how to make a future development to add bins 16-40 in an efficient manner for TOMAS40, since the template is already becoming quite lengthy with only bins 1-15.