Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dry deposition to snow and ice #2045

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

r-pound
Copy link
Contributor

@r-pound r-pound commented Nov 24, 2023

Name and Institution (Required)

Name: Ryan Pound
Institution: University of York

Confirm you have reviewed the following documentation

Describe the update

With the changes made in 13.4.0 (commit e593ccb, pull request #945) the method of calculating array IsSnow and other majority land cover types for grid boxes changed to use the native GEOS meteorological fields.

The result of switching from IsSnow being determined by surface albedo to the fraction of land covered with snow (FRSNO) has changed the behaviour of this array. Previously (due to surface albedo) this would be true for any grid box containing a majority of snow, land ice or sea ice.

This is no longer the case and only represents grid boxes with a majority of snow cover. Several sections of drydep_mod.f90 have historically used the IsSnow array to update dry deposition calculations to account for special cases of dry deposition to snow/ice. However since the land cover arrays were updated to use the native fields, these special case determinations have not been updated to reflect the current state of these arrays, apart from Update drydep code for assigning pH over land, ocean, and ice (pull request #1435) which updated the code to reflect the need to use both IsSnow and IsIce to determine if the tile is a majority snow or ice cover.

Expected changes

For the dry deposition of ozone, this restores dry deposition velocity calculation behaviour to that expected from #997. This increases surface ozone over predominantly ice and snow-covered regions, with everywhere else experiencing negligible change.

image

image

This also results in similar changes for other species, however, this should be reverting model behaviour back to that of pre-version 13.4.0 where IsSnow was calculated based on surface albedo.

I also recommend the inclusion of change in dry deposition plots within the benchmarks. I can supply the Python script used to generate this analysis if that would help.

@msulprizio msulprizio added the category: Bug Fix Fixes a previously-reported bug label Nov 27, 2023
@msulprizio msulprizio self-assigned this Nov 27, 2023
@msulprizio
Copy link
Contributor

Thanks @r-pound. I have added this bug fix to our model development priority page for inclusion in 14.3.0.

Also tagging Surface-Atmosphere Exchange Working Group Co-Chairs @jgeddes85 @cdholmes @amospktai

@@ -479,7 +479,7 @@ SUBROUTINE UPDATE_DRYDEPFREQ( Input_Opt, State_Chm, State_Diag, State_Grid, &
!-----------------------------------------------------------
! Special treatment for snow vs. ice
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this section treats snow and ice the same I think we should update this comment to be "Special treatment for snow and ice". Having "vs" makes it look like they are treated differently.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. The comment felt a bit ambiguous to me so I left it as is in case anyone more knowledgeable about this specific case wanted to suggest a different approach. Based on how IsSnow used to be defined it will have always treated snow and ice the same until 13.4 so my gut feeling is that it should read

Special treatment for snow and ice

as you suggested

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment is now fixed in c23b1ef.

@lizziel
Copy link
Contributor

lizziel commented Nov 28, 2023

Good catch that the pre-13.4 version of IsSnow included ice and thus there were parts of drydep_mod.F90 that needed updating but weren't. Thanks for finding this!

@msulprizio msulprizio changed the base branch from main to dev/14.3.0 December 1, 2023 12:45
@msulprizio msulprizio added this to the 14.3.0 milestone Dec 1, 2023
@msulprizio msulprizio merged commit c23b1ef into geoschem:dev/14.3.0 Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Fix Fixes a previously-reported bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants