Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Ryan Pound
Institution: University of York
Confirm you have reviewed the following documentation
Describe the update
With the changes made in 13.4.0 (commit e593ccb, pull request #945) the method of calculating array IsSnow and other majority land cover types for grid boxes changed to use the native GEOS meteorological fields.
The result of switching from IsSnow being determined by surface albedo to the fraction of land covered with snow (FRSNO) has changed the behaviour of this array. Previously (due to surface albedo) this would be true for any grid box containing a majority of snow, land ice or sea ice.
This is no longer the case and only represents grid boxes with a majority of snow cover. Several sections of drydep_mod.f90 have historically used the IsSnow array to update dry deposition calculations to account for special cases of dry deposition to snow/ice. However since the land cover arrays were updated to use the native fields, these special case determinations have not been updated to reflect the current state of these arrays, apart from
Update drydep code for assigning pH over land, ocean, and ice
(pull request #1435) which updated the code to reflect the need to use both IsSnow and IsIce to determine if the tile is a majority snow or ice cover.Expected changes
For the dry deposition of ozone, this restores dry deposition velocity calculation behaviour to that expected from #997. This increases surface ozone over predominantly ice and snow-covered regions, with everywhere else experiencing negligible change.
This also results in similar changes for other species, however, this should be reverting model behaviour back to that of pre-version 13.4.0 where IsSnow was calculated based on surface albedo.
I also recommend the inclusion of change in dry deposition plots within the benchmarks. I can supply the Python script used to generate this analysis if that would help.