Add missing units in comments of KPP/fullchem/commonIncludeVars.sh #2061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses issue #2029 by @jessicahaskins: KPP/fullchem/commonIncludeVars.H - Update units (in comment) for SR_MW in comment line - Add units (in comment) for PRESS, RELHUM, SUNCOS, PHOTOL, H2O, K_STRAT, K_TROP, TROP Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
TODO: Documentation
yantosca
added
the
no-diff-to-benchmark
|
All GEOS-Chem Classic integration tests (except TOMAS) passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
GCClassic #cfb0626 GEOS-Chem Classic 14.2.3 release
GEOS-Chem #60c682c32 Merge PR #2061 (Add missing units in commonIncludeVars.H)
HEMCO #a5d5169 HEMCO 3.7.2 release
Using 24 OpenMP threads
Number of execution tests: 27
Submitted as SLURM job: 11842420
==============================================================================
Summary of test results:
------------------------------------------------------------------------------
Execution tests passed: 25
Execution tests failed: 2
Execution tests not yet completed: 0Furthermore, all integration tests were zero-diff w/r/t 14.2.3, except for:
|
msulprizio
reviewed
Dec 6, 2023
msulprizio
approved these changes
Dec 6, 2023
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
GCHP #3a1a52f GCHP 14.2.3 release
GEOS-Chem #60c682c32 Merge PR #2061 (Add missing units in commonIncludeVars.H)
HEMCO #a5d5169 HEMCO 3.7.2 release
Number of execution tests: 5
Submitted as SLURM job: 11853069
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GCHP integration tests were also zero-diff w/r/t 14.2.3. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca
Institution: Harvard + GCST
Confirm you have reviewed the following documentation
Describe the update
This is the companion PR for issue #2029 (by @jhaskinsPhD). This is a documentation update that adds missing units to the comments in
KPP/fullchem/commonIncludeVars.H:Expected changes
This is a zero-diff update as it only touches comments in an include file. The KPP mechanisms were not rebuilt.
Reference(s)
N/A
Related Github Issue(s)