Fix unit conversion code for TOMAS following merge with 14.2.3 #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling with TOMAS=on was failing because the TOMAS code in fullchem_mod.F90 still used character strings for units instead of the integer values that were implemented in 14.3.2. This is now updated. Signed-off-by: Melissa Sulprizio <[email protected]>
yantosca
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio
Institution: Harvard / GCST
Describe the update
Compiling with TOMAS=on was failing because the TOMAS code in fullchem_mod.F90 still used character strings for units instead of the integer values that were implemented in 14.3.2. This is now updated.
Expected changes
This is a zero-difference update that allows GEOS-Chem to compile with the TOMAS option on.