Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for GEOS-Chem 14.3 in CESM #2154

Merged
merged 13 commits into from
Mar 18, 2024

Conversation

lizziel
Copy link
Contributor

@lizziel lizziel commented Feb 15, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Describe the update

This PR contains minor updates and fixes to enable building and running GEOS-Chem 14.3 in the CESM model. It must be merged in at the same time as Cloud-J updates in geoschem/Cloud-J#2.

Expected changes

This is a no diff update.

Reference(s)

None

Related Github PR(s)/Issue(s)

@lizziel lizziel added no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: CESM Related to running GEOS-Chem in CESM labels Feb 15, 2024
@yantosca yantosca self-requested a review February 15, 2024 17:45
@lizziel lizziel force-pushed the feature/geos-chem_14.3_in_cesm branch from 6116efa to 7913a31 Compare March 11, 2024 19:07
@lizziel
Copy link
Contributor Author

lizziel commented Mar 11, 2024

This is ready for review but not ready for merge. I need to make a few updates to Cloud-J standalone for geoschem/Cloud-J#2, and this PR is dependent on that PR.

@lizziel lizziel marked this pull request as ready for review March 11, 2024 19:46
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lizziel, this mostly looks good. Can you doublecheck the data paths for the GMI files, I think the paths should be e.g. $ROOT/GMI/v2015-02/... etc.

run/CESM/HEMCO_Config.rc Outdated Show resolved Hide resolved
@lizziel
Copy link
Contributor Author

lizziel commented Mar 14, 2024

The Cloud-J PR that goes with this PR is now ready for review. geoschem/Cloud-J#2

lizziel added 13 commits March 14, 2024 09:14
Signed-off-by: Lizzie Lundgren <[email protected]>
CESM requires a netcdf file containing a list of gas phase dry deposited
species and their molecular weights and Henry's Law coefficients. Having
the script within the GEOS-Chem source code is advantageous because
it can be updated at the same time that species lists change in GEOS-Chem.

Signed-off-by: Lizzie Lundgren <[email protected]>
Fast-JX is no longer used in GEOS-Chem runs within CESM. It can still be
run if passed compiler flag for it, but with this update it will then read
photolysis ascii files from a processors, not just root.

Signed-off-by: Lizzie Lundgren <[email protected]>
Some emissions are handled differently in CESM and notes in HEMCO_Config.rc
document this.

Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
@lizziel lizziel force-pushed the feature/geos-chem_14.3_in_cesm branch from 2868090 to 3900e01 Compare March 14, 2024 15:16
Copy link
Contributor

@yantosca yantosca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lizziel. Looks good!

@yantosca yantosca self-assigned this Mar 14, 2024
@yantosca yantosca added category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models topic: Structural Modifications Related to GEOS-Chem structural modifications (as opposed to scientific updates) labels Mar 14, 2024
@yantosca yantosca added this to the 14.3.1 milestone Mar 14, 2024
@yantosca
Copy link
Contributor

All GEOS-Chem Classic integration tests passed

==============================================================================
GEOS-Chem Classic: Execution Test Results

GCClassic #1672a99 HEMCO submod update: Merge PR #263 (Restrict volcano clim printout)
GEOS-Chem #9c5803931 Merge PR #2154 (Updates for GEOS-Chem 14.3 in CESM)
HEMCO     #22de25e Merge PR #263 (Restrict volcano clim prints to root thread)

Using 24 OpenMP threads
Number of execution tests: 26

Submitted as SLURM job: 23809135
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also, all integration tests were zero-diff w/r/t 14.3.0 except:

  • APM (known parallelization issue)
  • RRTMG (numerical noise in RRTMG collection file)

@yantosca
Copy link
Contributor

After merging geoschem/GCHP#396, all GCHP integration tests passed:

==============================================================================
GCHP: Execution Test Results

GCHP      #6ca8b1f Add new pre-processor definition GCHP_WRAPPER for use in submodules
GEOS-Chem #9c5803931 Merge PR #2154 (Updates for GEOS-Chem 14.3 in CESM)
HEMCO     #22de25e Merge PR #263 (Restrict volcano clim prints to root thread)

Number of execution tests: 6

Submitted as SLURM job: 23864207
==============================================================================
 
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%%  All execution tests passed!  %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

Also all GCHP integration tests were zero-diff w/r/t 14.3.0.

@msulprizio msulprizio deleted the feature/geos-chem_14.3_in_cesm branch May 30, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Interface to External Model Related to GEOS-Chem updates needed to interface with other models no-diff-to-benchmark This update will not change the results of fullchem benchmark simulations topic: CESM Related to running GEOS-Chem in CESM topic: Structural Modifications Related to GEOS-Chem structural modifications (as opposed to scientific updates)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants