Remove override file

[etj]

The file

geofence/WEB-INF/classes/geofence-datasource-ovr.properties

prevents user override file to be used, and should be removed.

The issue is both in

• master: https://github.com/geoserver/geofence/blob/master/src/gui/web/src/main/resources/geofence-datasource-ovr.properties
• 2.2.x: https://github.com/geoserver/geofence/blob/2.2.x/src/gui/web/src/main/resources/geofence-datasource-ovr.properties

[etj]

In general, users should define their own override file: see https://github.com/geosolutions-it/geofence/wiki/GeoFence-configuration#providing-a-configuration-file for details.

The persistencemodule defines an overrider which loads the file classpath*:geofence-datasource-ovr.properties. This definition is used in almost every geofence module, where a file geofence-datasource-ovr.properties is located in the test/resources directory.
The web module anyway inherits this overrider, and any geofence-datasource-ovr.properties file will be loaded, leading to potential race conditions. Internal usage of this ovr configuration only provides one such file at any time.

Please note that the user-defined ovr file will have higher priority wrt to the geofence-datasource-ovr.properties, that should only be used for internal purposes.

Anyway, in order to have less configuration files around, distributing an internal fixed ovr file should be avoided. Probably the best way to deal with default values should be setting them into the properties field in the overrider definition inside the applicationContext.xml file.