Fix data-dir backend race conditions loading or creating ServiceInfos #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d3b4233.
Upstream's `DefaultGeoServerLoader` has a couple issues when it comes to multiple instances starting up at the same time: * creates the ServiceInfos, but doesn't persist them * does not set GeoServer#setGlobal and GeoServer#setLogging if they're not persisted * there's a race condition where each service instance will end up with service infos with different ids for the same service. The fix involves loading the config while grabbing a lock, and persisting any newly-created ServiceInfo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream's
DefaultGeoServerLoaderhas a couple issues whenit comes to multiple instances starting up at the same time:
if they're not persisted
up with service infos with different ids for the same service.
The fix involves loading the config while grabbing a lock,
and persisting any newly-created ServiceInfo.
Fixes #104