Fix invalid virtual service endpoints not returning 404 #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an invalid virtual service request is made (e.g.
to a non existing workspace or layer), upstream
GeoServer will return a 404 thanks to `OWSHandlerMapping`
checking for the workspace/layergroup/layer and returning
a `null` request handler.
Spring-boot does not automatically engages the `OWSHandlerMapping`
beans in the request lifecycle.
This patch creates separate controller entry points for
`/{virtualService}/<ows service>` and
`/{virtualService}/{layer}/<ows service>`, using a helper
service bean to verify the existence of the requested
workspace/layergroup and layer, returning a 404 with
an explanatory message if the virtual service is not found,
and hence avoiding to return the full layer list in
getcapabilities requests instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid virtual service request is made (e.g.
to a non existing workspace or layer), upstream
GeoServer will return a 404 thanks to
OWSHandlerMappingchecking for the workspace/layergroup/layer and returning
a
nullrequest handler.Spring-boot does not automatically engages the
OWSHandlerMappingbeans in the request lifecycle.
This patch creates separate controller entry points for
/{virtualService}/<ows service>and/{virtualService}/{layer}/<ows service>, using a helperservice bean to verify the existence of the requested
workspace/layergroup and layer, returning a 404 with
an explanatory message if the virtual service is not found,
and hence avoiding to return the full layer list in
getcapabilities requests instead.
Fixes #24