Fix gwc's direct WMS integration, bean registration race condition #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make wms-service's application autoconfiguration run before gwc's `WMSIntegrationAutoConfiguration`. They both load beans from `gs-wms.jar` but of gwc's autoconfiguration runs first, precludes wms's autoconfiguration from loading some beans, as they're already marked to be ignored. This resulted in direct-wms-integration being absent despite the configuration property `gwc.wms-integration=true`.
groldan
force-pushed
the
bug/wms_gwc_integration_broken
branch
from
b8554c2 to
4a81c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make wms-service's application autoconfiguration run before
gwc's
WMSIntegrationAutoConfiguration. They both loadbeans from
gs-wms.jarbut of gwc's autoconfiguration runsfirst, precludes wms's autoconfiguration from loading some
beans, as they're already marked to be ignored.
This resulted in direct-wms-integration being absent despite
the configuration property
gwc.wms-integration=true.