Improvement/xml resource loader startup #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 79e8242.
A ~1.5 seconds startup time improvement, provided by `FilteringXmlBeanDefinitionReader` caching parsed XML documents by Resource URI, since many configurations can try to load different sets of beans from the same xml document, and all the classpath Resource's to avoid loading them all for each location. `FilteringXmlBeanDefinitionReaderAutoConfiguration` clears the caches once the application context is refreshed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve startup time by caching XML classpath resources
A ~1.5 seconds startup time improvement, provided by
FilteringXmlBeanDefinitionReadercaching parsed XMLdocuments by Resource URI, since many configurations can try to load different sets of beans from the same
xml document, and all the classpath Resource's to avoid loading them all for each location.
FilteringXmlBeanDefinitionReaderAutoConfigurationclears the caches once the application context is refreshed.