Spawn reload and reset actions to all pods #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce ResetEvent and ReloadEvent to be triggered when a node is instructed to reset or reload the configuration, respectively, and publish them as distributed events for all the nodes in the cluster to react accordingly. Co-authored-by: Nils Bühner <[email protected]>
…level
* Prevent double event dispatching. Reload implies reset, avoid
sending both events on reload().
* Revert changes to GeoServerImpl (overloading of resert() and reload()
with a bolean `silent` argument). It doesn't prevent that once the
Catalog and/or the GeoServer are reloaded, while the newly loaded
objects are sync'ed to the in-memory one, CatalogInfoAdded and
ConfigInfoAdded events are sent to all pods, and these ones in turn
also do so, resulting in an explosion of events.
Instead, disable event publishing completely while reload() and
reset() are being processed:
* `CatalogApplicationEventPublisher` gets new methods:
`disable()`, `enable()`, and `enabled():boolean`.
* `GeoServerLifecycleEventPublisher.beforeReload()` sends the
`ReloadEvent` and disables event publishing while `reload()` is
processed locally.
* `GeoServerLifecycleEventPublisher.reloaded()` re-enables event
publishing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suggests emitting the newly introduced
LifecycleEventevents on reset (ResetEvent) and reload (ReloadEvent) respectively. Connected services will receive these events to reload and/or reset their catalog and configuration.Care is taken that a chain of events is not triggered while each node reloads the catalog and config.
Supersedes #528
Fixes #518
Authored by: @buehner, @dnlkoch, @groldan