Timeline error in epic "setIsIntervalData"

[allyoucanmap]

Description

How to reproduce

• login as admin
• open this map https://dev-mapstore.geosolutionsgroup.com/mapstore/#/viewer/openlayers/40116

Expected Result

We should fix the error and verify why is it not able to compute the result for the setIsIntervalData flow

Current Result

• error in console

Error in epic "setIsIntervalData". Original error: TypeError: Cannot read properties of null (reading 'indexOf')

• Not browser related

Browser info

(use this site: https://www.whatsmybrowser.org/ for non expert users)

Browser Affected	Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

map for testing
timeline-map.zip

[tdipisa]

@dsuren1 I need first of all an investigation to understand if this issue is a regression or not included after recent updates we provided for the timeline (eg. #7958).

[dsuren1]

@tdipisa
This issue is a regression caused by this #8229 part of #7958 which introduced the new epics setIsIntervalData.

Problem is caused because the setIsIntervalData epics is executed even when no layer is selected which is required to generate arguments for getDomainValues service.
Hence an undefined url is used to fire domain service call resulting in null values of next and previous time value causing the exception.

Occurrences

• On updating layer dimension data onMapConfigLoad
• On traversing time when Snap to guide layer is disabled

Solution
Allow setIsIntervalData epics execution only layer is selected (timeline -> selectedLayer)

I will provide fix as part this issue itself.

[tdipisa]

@ale-cristofori do you see any cons in what proposed by @dsuren1 above?

[ale-cristofori]

@tdipisa @dsuren1 no, but I would refactor the epic with two epics to keep concerns separated.

the one that listens for SELECT_LAYER will get the layerId from the action and filter out those layers that do not have an ID, like in this case the layer has not been loaded correctly.

the one that listens for SET_CURRENT_TIME will get the layerId from the state with selectedLayerSelector

MapStore2/web/client/epics/playback.js

Line 369 in 13d6dea

.filter(({type, layerId}) => (type === SET_CURRENT_TIME || (type === SELECT_LAYER && layerId)))

[dsuren1]

@ale-cristofori
From what I can infer, the problem is caused only by SET_CURRENT_TIME when no layer is selected and the value of selectedLayerSelector is undefined, i.e the layerId cannot be acquired from the selector.
So in domainArgs the value of selectedLayerUrl becomes undefined causing the error. Which can still happen with a separate epics.

How should we pick the layer to be used in this scenario, should we go with the first layer instead?

[ale-cristofori]

@dsuren1 if the purpose is to avoid the request being fired with undefined layerId, shouldn't this cover both cases?

export const setIsIntervalData = (action$, { getState = () => { } } = {}) =>
    action$.ofType(SET_CURRENT_TIME, SELECT_LAYER)
        .filter(({layerId}) => layerId || selectedLayerSelector(getState()))
        .switchMap(({time: actionTime}) => getTimeIsInterval(actionTime, getState));

But maybe I am missing something. Let me know

[dsuren1]

@dsuren1 if the purpose is to avoid the request being fired with undefined layerId, shouldn't this cover both cases?

export const setIsIntervalData = (action$, { getState = () => { } } = {}) =>
    action$.ofType(SET_CURRENT_TIME, SELECT_LAYER)
        .filter(({layerId}) => layerId || selectedLayerSelector(getState()))
        .switchMap(({time: actionTime}) => getTimeIsInterval(actionTime, getState));

But maybe I am missing something. Let me know

@ale-cristofori
That's exactly the solution I proposed in my comment above :)

Kindly let me know if I can proceed with it.

[ale-cristofori]

@dsuren1, sorry I typed that response yesterday, end of working day and I re-thought about it this morning. You can proceed with it, I tested and it seems the specific error is gone