Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 'Height from terrain' measurement #9549

Closed
1 task done
tdipisa opened this issue Oct 3, 2023 · 1 comment · Fixed by #9811
Closed
1 task done

Issue with 'Height from terrain' measurement #9549

tdipisa opened this issue Oct 3, 2023 · 1 comment · Fixed by #9811
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT new
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Oct 3, 2023

Description

Height from terrain measure in 3D mode doesn't seem to report the correct height in certain cases

How to reproduce

  • Open this map
  • Switch to 3D mode and activate the Measurement tool
  • Activate the Height from terrain measurement
  • Do a measurement with and without the Genova 3D layer active in TOC

Expected Result

The measurement tool should always provide the correct measurement value and properly handle corner cases by notifying the user if necessary (e.g. a measurement cannot be performed on a certain location for a specific reason).

Current Result

With mesh active in TOC
Image

With mesh not active in TOC (same location)
Image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@tdipisa tdipisa added 3D All issues related to the 3D rendering in CesiumJs bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT estimate needed new labels Oct 3, 2023
@tdipisa tdipisa self-assigned this Oct 3, 2023
@tdipisa tdipisa assigned allyoucanmap and unassigned tdipisa Oct 3, 2023
@tdipisa tdipisa removed the new label Oct 4, 2023
@tdipisa
Copy link
Member Author

tdipisa commented Nov 21, 2023

Connected to #9548

It seems the native function of Cesium pickPosition has some problems that has not completely resolved yet (see here). After some quick tests I think we could only partially mitigate it by applying one of the following:

  • Option 1) try to improve the pickPosition detection by selecting only specific feature for this purpose and excluding feature that will return wrong position such as GroundPrimitive or GroundPolylinePrimitive (It seems to work but there are still some edge cases eg intersection of a 3D tiles feature and terrain)
  • Option 2) use only drillPickFromRay to intersect features in combination with globe pick. Note that drillPickFromRay is a private function and it’s not documented in the official Cesium documentation. (Seems to work but worried about performance and private method)
  • Option 3) Evaluate if other picking options are available in Cesium (Not found other options at the moment)

Then we have to:

  • Ensure that dynamic billboard and primitive are not included in the pick workflow of drawing and modify in Cesium. They should be added inside the _getObjectsToExcludeOnPick function

@tdipisa tdipisa added the new label Dec 1, 2023
@tdipisa tdipisa self-assigned this Dec 6, 2023
@tdipisa tdipisa added this to the 2023.02.02 milestone Dec 6, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Dec 7, 2023
@mahmoudadel54 mahmoudadel54 linked a pull request Dec 12, 2023 that will close this issue
12 tasks
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 22, 2023
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Dec 22, 2023
@tdipisa tdipisa modified the milestones: 2023.02.02, 2024.01.00 Jan 9, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants