Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with 3D Point measurement #9548

Closed
1 task done
tdipisa opened this issue Oct 3, 2023 · 2 comments · Fixed by #9811 or #9909
Closed
1 task done

Issue with 3D Point measurement #9548

tdipisa opened this issue Oct 3, 2023 · 2 comments · Fixed by #9811 or #9909
Assignees
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT
Milestone

Comments

@tdipisa
Copy link
Member

tdipisa commented Oct 3, 2023

Description

Height from terrain measure in 3D mode doesn't seem to report the correct values (coordinates and height) in certain cases.

How to reproduce

  • Open this map
  • Switch to 3D mode and activate the Measurement tool
  • Activate the Point coordinates measurement
  • Move the mouse hover the map and check the coordinate value reported by the measurement popup
  • Click on the map (performing the measurement) and check the coordinate value reported by the measurement popup

Expected Result

The measurement tool should always provide the correct measurement value and properly handle corner cases by notifying the user if necessary (e.g. a measurement cannot be performed on a certain location for a specific reason).

Current Result

Image

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@tdipisa tdipisa added 3D All issues related to the 3D rendering in CesiumJs bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT estimate needed new labels Oct 3, 2023
@tdipisa tdipisa self-assigned this Oct 3, 2023
@tdipisa tdipisa changed the title Issue with 3D point measurement Issue with 3D Point measurement Oct 3, 2023
@tdipisa tdipisa assigned allyoucanmap and unassigned tdipisa Oct 3, 2023
@tdipisa tdipisa removed the new label Oct 4, 2023
@tdipisa
Copy link
Member Author

tdipisa commented Nov 21, 2023

This problem seems related to the issue #9549 Issue with 'Height from terrain' measurement. The pickPosition is not working as expected in particular when intersecting a billboard. In this case the billboard was used as a cursor. All the dynamic billboard and primitives should be excluded by the pick workflow computation. In addition we need to mitigate the problem of position computation as described in #9549.

@tdipisa tdipisa added the new label Dec 1, 2023
@tdipisa tdipisa self-assigned this Dec 6, 2023
@tdipisa tdipisa modified the milestones: 2024.01.00, 2023.02.01, 2023.02.02 Dec 6, 2023
@tdipisa tdipisa assigned mahmoudadel54 and unassigned tdipisa Dec 7, 2023
mahmoudadel54 added a commit to mahmoudadel54/MapStore2 that referenced this issue Dec 12, 2023
@mahmoudadel54 mahmoudadel54 linked a pull request Dec 12, 2023 that will close this issue
12 tasks
@ElenaGallo ElenaGallo added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Dec 22, 2023
@ElenaGallo ElenaGallo assigned tdipisa and ElenaGallo and unassigned tdipisa Dec 22, 2023
@tdipisa tdipisa modified the milestones: 2023.02.02, 2024.01.00 Jan 9, 2024
@tdipisa tdipisa removed the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Jan 9, 2024
@tdipisa
Copy link
Member Author

tdipisa commented Jan 24, 2024

Coordinates are still expressed in radiants. This still need to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3D All issues related to the 3D rendering in CesiumJs Accepted bug C040-COMUNE_GE-2023-CUSTOM-SUPPORT
Projects
None yet
4 participants