Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend the GeoProcessing tool to work with client side Vector layers as WPS inputs #9685

Closed
10 tasks
MV88 opened this issue Nov 8, 2023 · 1 comment · Fixed by #9691, #9809 or #9835
Closed
10 tasks

Extend the GeoProcessing tool to work with client side Vector layers as WPS inputs #9685

MV88 opened this issue Nov 8, 2023 · 1 comment · Fixed by #9691, #9809 or #9835

Comments

@MV88
Copy link
Contributor

MV88 commented Nov 8, 2023

Description

It is requested a new additional feature based on the recently developed GeoProcessing tool for supported Intersection and Buffer processes.
The existing tool functionalities are expecting to be used only for WMS and/or WFS layers in TOC as inputs for aforementioned processes.
As part of this work it is requested to extend the current tool to also support vector layers defined or imported on the client side.

Possible use case scenarios to supports are:

  • Use the output of the GeoProcessing tool (vector layers generated by a buffer or intersection geoprocess) for performing another operation using it as a new input
  • Use an imported vector layer (SHP, GeoJson, KML etc) as an input for the GeoProcessing tool
  • Use existing annotations as an input for the GeoProcessing tool (to check if possible, it could be excluded initially since we have a new implementation in master)
  • Use vector layers TOC coming from measurements

In all cases the UX should be the same and well consistent.

Acceptance criteria

  • Allow local vector layers listed above to be used as input in the GeoProcessing plugin
    • measurements
    • imported GeoJSON
    • imported Shapefiles
    • other imports
    • annotations
  • make sure that the CollectGeometries request sent to the backend is adapted for vector layers
  • handle cases where Geometry collection is generated from a vector layer, because buffer and intersect processes fails with it, we should prevent the user to click run and notifying it via user feedback
  • for intersection it should maintain the previous checks we do, first layer/ feature can't be a point
  • Add possibility to configure a predefined geoserver url to be used as a fallback within process requests when the source layer is a local vector layer

Other useful information

@MV88 MV88 added New Feature used for new functionalities C265-ATOLCD-2022-SUPPORT labels Nov 8, 2023
@MV88 MV88 added this to the 2023.02.01 milestone Nov 8, 2023
@MV88 MV88 self-assigned this Nov 8, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Nov 10, 2023
… Geo_Processing tool

* refactored the way the counter for each tool is handled
* add possibility to configure a wpsUrl to be used as default source in the plugin otherwise the url from the layer will be used
@MV88 MV88 added the BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch label Nov 10, 2023
@MV88 MV88 linked a pull request Nov 10, 2023 that will close this issue
12 tasks
@tdipisa tdipisa added enhancement and removed New Feature used for new functionalities labels Nov 10, 2023
@tdipisa tdipisa modified the milestones: 2023.02.01, 2023.02.02 Nov 27, 2023
@MV88 MV88 closed this as completed in #9691 Dec 6, 2023
MV88 added a commit that referenced this issue Dec 6, 2023
…ool (#9691)

* Fix #9685 Add possibility tyo use vector layers inside Geo_Processing tool

* refactored the way the counter for each tool is handled
* add possibility to configure a wpsUrl to be used as default source in the plugin otherwise the url from the layer will be used

* refactor: moved some utilities in dedicated utils file

* improved feedback in case wpsUrl is missing

* improve feedback also for buffer tool

* better handling misconfigured layer in buffer tool

* Fixed review points

* better clean up of highlighted features
* fixed layer used in intersection process
* fiz zoom to feature when selected

* fix test
@ElenaGallo ElenaGallo self-assigned this Dec 7, 2023
MV88 added a commit to MV88/MapStore2 that referenced this issue Dec 12, 2023
tdipisa pushed a commit that referenced this issue Dec 18, 2023
* Fix #9685 measurements issues and added some enhancements to it

* adding some extra tests

* Fixed problems related to measurements and missing ids

* refactor and optimization

* final fixes for vector layers for the click on map action

* fix geodesic circle

* Fix tests
MV88 added a commit to MV88/MapStore2 that referenced this issue Dec 19, 2023
…GeoProcessing tool (geosolutions-it#9691)

* Fix geosolutions-it#9685 Add possibility tyo use vector layers inside Geo_Processing tool

* refactored the way the counter for each tool is handled
* add possibility to configure a wpsUrl to be used as default source in the plugin otherwise the url from the layer will be used

* refactor: moved some utilities in dedicated utils file

* improved feedback in case wpsUrl is missing

* improve feedback also for buffer tool

* better handling misconfigured layer in buffer tool

* Fixed review points

* better clean up of highlighted features
* fixed layer used in intersection process
* fiz zoom to feature when selected

* fix test
MV88 added a commit to MV88/MapStore2 that referenced this issue Dec 19, 2023
…nts to it (geosolutions-it#9809)

* Fix geosolutions-it#9685 measurements issues and added some enhancements to it

* adding some extra tests

* Fixed problems related to measurements and missing ids

* refactor and optimization

* final fixes for vector layers for the click on map action

* fix geodesic circle

* Fix tests
# Conflicts:
#	web/client/epics/widgets.js
#	web/client/reducers/config.js
#	web/client/utils/LayersUtils.js
@tdipisa
Copy link
Member

tdipisa commented Jan 8, 2024

@ElenaGallo take care of this #9691 (comment) for the related documentation.

offtherailz pushed a commit that referenced this issue Jan 9, 2024
@ElenaGallo ElenaGallo added Accepted and removed BackportNeeded Commits provided for an issue need to be backported to the milestone's stable branch Accepted labels Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment