#10766: Remove error notified by GeoFence when moving a rule for geofence stand-alone version only #10767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a rule for geofence stand-alone version only Description: - fixing the shown error by moving the RULE_SAVED action to be after move rule in case full update and throw error only if addRule is failed
Closed
1 task
tdipisa
added
the
BackportNeeded
|
@ElenaGallo please test in DEV and let us know if we can backport. |
|
@tdipisa it cannot be tested in our dev, this specific issue happens with a dedicated instance of geofence |
@MV88 I'm sorry, why? We have the rule manager in DEV. Anyway, if it is not possible to reproduce it now in QA at the moment (where the GF role manager is also present) we can manage to test in a dedicated test environment we have for this @ElenaGallo. |
mahmoudadel54
added a commit
to mahmoudadel54/MapStore2
that referenced
this pull request
Jan 22, 2025
…a rule for geofence stand-alone version only (geosolutions-it#10767) Description: - fixing the shown error by moving the RULE_SAVED action to be after move rule in case full update and throw error only if addRule is failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixed the shown error for user in rule manager page that happens while trying to edit priority. Handling this was by moving the RULE_SAVED action to be after move rule in case full update and throw error only if addRule is failed
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#10766
What is the new behavior?
The edit priority can be edited successfully without showing any error notification messages.
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
This issue is just for the geofence stand-alone version only