Remove redundant vector layer feature initialization #1206
Conversation
manisandro
force-pushed
the
vectorfeatures
branch
from
c0f1d05 to
85c27cf
Compare
manisandro
force-pushed
the
vectorfeatures
branch
from
85c27cf to
a5b2a8b
Compare
| @@ -106,23 +106,7 @@ var styleFunction = function(feature) { | |||
|
|
|||
| Layers.registerType('vector', { | |||
| create: (options) => { | |||
| let features; | |||
There was a problem hiding this comment.
This is needed to allow configuring the layer via JSON instead of using Feature.jsx components
There was a problem hiding this comment.
Uhm, there needs to be a way to suppress this though, since when adding a vector layer to the layers state, Feature.jsx objects are created automatically. This leads to those Feature.jsx objects being correctly managed whereas those added directly are unmanaged, meaning they are not removed anymore when changing the layer properties (i.e. changing the features field) without removing and re-adding the layer. I don't know the JSON use-case, do you see a solution?
There was a problem hiding this comment.
I need to do some testing, I will let you know...
There was a problem hiding this comment.
@mbarto Did you manage to have a look at this?
There was a problem hiding this comment.
It should be fixed by this commit, using forceUpdate.
d33e1f8#diff-b2a987f6d21da3daede77b61016d2380R129
Can you confirm?
There was a problem hiding this comment.
Unfortunately I still end up with unmanaged features using latest master.
offtherailz
changed the title
map/openlayers/plugins/VectorLayer.jsis redundant and leads to features added directly to the openlayers layer which are unmanaged by react: the features are already managed in the wrapper class inmap/openlayers/Feature.jsxthis.layermember inmap/openlayers/Layer.jsxneeds to be a state, otherwise the component isn't updated when the actual layer is constructed inthis.addLayer, leading toconst children = layer ? [...] : nullinrender()yieldingchildren = nullthe very first time the layer component is rendered, because the layer wasn't yet constructed. Unlesslayeris part of the state, the component won't get refreshed whenlayeris initialized, meaning that the layer component will only be correctly rendered on the next action which triggers a repaint.