Fix infinite loop when query panel is closed. #1377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbarto
suggested changes
Jan 10, 2017
| @@ -33,7 +33,7 @@ const MapPlugin = React.createClass({ | |||
| }, | |||
| getDefaultProps() { | |||
| return { | |||
| mapType: 'leaflet', | |||
| mapType: 'cesium', | |||
There was a problem hiding this comment.
didn't wanted to commit that. sorry, I'm going to revert this change
mbarto
approved these changes
Jan 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error happens when closing the query panel (in debug mode) .
This is due to the onClick event bind directly to the action, passing the wrong parameters (the mouseEvent instead of the search URL).
In debug this causes an immutable error, in general the state becomes not consistent anymore.