Add a button to open in full mapstore (see #1632) #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoFull plugins autoshows when originalUrl is present in config (JsAPI use case) or when the url match with a regex (embedded iframe use case). In both cases it opens MapStore full in a new tab (using originalUrl or parsing the current href to create the url to open.
mbarto
suggested changes
Apr 6, 2017
web/client/plugins/GoFull.jsx
Outdated
| }, | ||
|
|
||
| render() { | ||
| if (!this.display()) return <noscript></noscript>; |
web/client/plugins/GoFull.jsx
Outdated
| * @memberof plugins | ||
| * @class | ||
| */ | ||
| const GoFull = React.createClass({ |
There was a problem hiding this comment.
Externalize the component, please
mbarto
approved these changes
Apr 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoFull plugins autoshows when originalUrl is present in config (JsAPI use case) or when the url match with a regex (embedded iframe use case).
In both cases it opens MapStore full in a new tab (using originalUrl or parsing the current href to create the url to open.