Fix #1957. Role filter for create new map #1958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix geosolutions-it#1957. Now you can confiure the plugin to display only for the allowedRoles in configuration
mbarto
reviewed
Jun 23, 2017
web/client/plugins/CreateNewMap.jsx
Outdated
| }, | ||
| contextTypes: { | ||
| router: React.PropTypes.object | ||
| }, | ||
| getDefaultProps() { | ||
| return { | ||
| mapType: "leaflet", | ||
| allowedRoles: ["ADMIN", "USER"], |
There was a problem hiding this comment.
but... do we have other roles? maybe we should use groups...
There was a problem hiding this comment.
By default all logged in, but we can deny for normal users via configuration.Using groups is a good idea for the future.
mbarto
suggested changes
Jun 26, 2017
web/client/plugins/CreateNewMap.jsx
Outdated
| @@ -18,7 +18,9 @@ class CreateNewMap extends React.Component { | |||
| mapType: PropTypes.string, | |||
| onGoToMap: PropTypes.func, | |||
| colProps: PropTypes.object, | |||
| isLoggedIn: PropTypes.bool | |||
| isLoggedIn: PropTypes.bool, | |||
| allowedRoles: React.PropTypes.array, | |||
There was a problem hiding this comment.
Remove React.PropTypes and use PropTypes
mbarto
approved these changes
Jun 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1957. Now you can confiure the plugin to display only for the allowedRoles in configuration