Fixes #2291 If a map save fails, user is not warned #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
offtherailz
approved these changes
Jan 12, 2018
mbarto
suggested changes
Jan 12, 2018
web/client/utils/LocaleUtils.js
Outdated
| @@ -51,6 +51,27 @@ const DATE_FORMATS = { | |||
| "it-IT": "dd/MM/yyyy", | |||
| "nl-NL": "dd/MM/yyyy" | |||
| }; | |||
|
|
|||
| const errorParser = { | |||
| geostore: { | |||
There was a problem hiding this comment.
I would register this handler in the GeoStoreAPI code, and put here a function to register the parsers
mbarto
suggested changes
Jan 16, 2018
web/client/utils/LocaleUtils.js
Outdated
| @@ -51,6 +51,18 @@ const DATE_FORMATS = { | |||
| "it-IT": "dd/MM/yyyy", | |||
| "nl-NL": "dd/MM/yyyy" | |||
| }; | |||
|
|
|||
| const servicesErrorParser = { | |||
| geostore: require('../api/GeoStoreDAO').errorParser | |||
There was a problem hiding this comment.
Can we do the opposite?
- registerParser = (type, parser) => {} in LocaleUtils
- registerParser('geostore', parser) in GeoStoreDAO
mbarto
approved these changes
Jan 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added feedback messages on save and save as.
Recognized errors: 403 - 404 - 409 - 500
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
What is the current behavior? (You can also link to an open issue here)
issue #2291
What is the new behavior?
Notifications feedback will be shown after saving
Does this PR introduce a breaking change? (check one with "x", remove the other)
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
Merge after #2495 Added details to Map because of conflict with success notification