Fix #2685. Removed for of statements #2714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
mbarto
reviewed
Mar 7, 2018
web/client/api/GeoStoreDAO.js
Outdated
| @@ -164,7 +164,7 @@ const Api = { | |||
| }, | |||
| updateResourcePermissions: function(resourceId, securityRules) { | |||
| let payload = "<SecurityRuleList>"; | |||
| for (let rule of securityRules.SecurityRuleList.SecurityRule) { | |||
| (securityRules && securityRules.SecurityRuleList && _.castArray(securityRules.SecurityRuleList.SecurityRule) || []).forEach( rule => { | |||
There was a problem hiding this comment.
Yes, I didn't want to change this part not covered by a test. going to externalize SecurityRule and test it
mbarto
approved these changes
Mar 7, 2018
offtherailz
added a commit
that referenced
this pull request
Mar 7, 2018
offtherailz
added a commit
to offtherailz/MapStore2
that referenced
this pull request
Mar 12, 2018
offtherailz
added a commit
that referenced
this pull request
Mar 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IE11 does not support for...of statements. I removed all of them. See notes below.
Issues
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other information:
I didn't find a way in lint to skip for...of statements
So I wasn't able create a test or avoid future problems of this kind