#7708 Allow latin chars in username and password #7723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MV88
requested changes
Jan 12, 2022
MV88
approved these changes
Jan 13, 2022
|
@ElenaGallo please test in DEV |
|
@ElenaGallo please test this in DEV as soon as you can and let me know when done. |
1 task
|
@offtherailz It is not possible to login with username or password without Latin characters. How to Reproduce
Current Result |
|
@offtherailz @ElenaGallo moving back to ready. We have to review what done @offtherailz. |
offtherailz
added a commit
that referenced
this pull request
Jan 13, 2022
MV88
pushed a commit
that referenced
this pull request
Jan 13, 2022
offtherailz
pushed a commit
to offtherailz/MapStore2
that referenced
this pull request
Jan 14, 2022
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR allows to use UTF-8 chars in username and password, by:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#7708
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information
We may need an extensive test bacause of the update of axios. Anyway the breaking changes are not so important to us (Typescript). I had to fix tests because of some fixes changes internal config checks, but I didn't noticed anything else).