Add linting tool: flake8 both to pyproject.toml and CI pipeline #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Aside from 'flake8' itself, one extra optional dependency (Flake8-pyproject) was added as flake8 does not support pyproject.toml yet. - For now I added all the existing flake8 warnings to 'ignore' entry in the pyproject.toml to be fixed later.
|
It seems that It has worked. At the end of CI log, it shows the |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
=======================================
Coverage 89.83% 89.83%
=======================================
Files 4 4
Lines 610 610
=======================================
Hits 548 548
Misses 62 62 ☔ View full report in Codecov by Sentry. |
|
LGTM. I've managed to remove the E712 exception but left the others (although those could be fixed too; I just couldn't do it now). Thanks again @abzrg! |
|
Happy to help (: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
With some investigations, I added an step in the
lintjob of github actions for flake8. Hope it's correct.For now, I added all the errors and warnings emitted by flake8 to the
ignoreentry to keep these commits simple.One of these warnings was about the length of the line. This can be configured in
pyproject.tomlfor both black (line-length) and flake8 (max-line-length). Some of the lines were above 200 chars of length, so I simply ignored that warning.Further, among these errors, I think the
E7121 warning can be simply fixed by replacing==withis Trueand!=withis not True.Let me know if you think I can help with any of these.
Footnotes
E712: comparison to
Trueshould be'if cond is True:'or'if cond:'↩