Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of keyword entries without values in FoamFiles #321

Merged
merged 2 commits into from
Mar 2, 2025
Merged

Conversation

gerlero
Copy link
Owner

@gerlero gerlero commented Mar 2, 2025

Fixes #320

@gerlero gerlero force-pushed the fix-320 branch 3 times, most recently from 4b083d3 to 10f11b8 Compare March 2, 2025 22:21
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2025

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.07%. Comparing base (2d71e04) to head (ea12ca0).

Files with missing lines Patch % Lines
foamlib/_files/_parsing.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
- Coverage   87.08%   87.07%   -0.02%     
==========================================
  Files          15       15              
  Lines        1402     1408       +6     
==========================================
+ Hits         1221     1226       +5     
- Misses        181      182       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gerlero gerlero merged commit 7b9d666 into main Mar 2, 2025
40 checks passed
@gerlero gerlero deleted the fix-320 branch March 2, 2025 22:42
@bevanwsjones
Copy link

@gerlero Thank you for the fix. Can further confirm it's working now 😄 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty Dictionary Crashes.
3 participants