Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove manual RawInputStream wrapper in client.logs() #21

Open
gesellix opened this issue Oct 9, 2015 · 2 comments
Open

remove manual RawInputStream wrapper in client.logs() #21

gesellix opened this issue Oct 9, 2015 · 2 comments

Comments

@gesellix
Copy link
Owner

gesellix commented Oct 9, 2015

The manual wrapping is currently necessary due to the remote api always returning text/plain content-type headers, so that the automated behaviour won't work. See moby/moby#16885

As soon as the Docker deamon behaves as expected, the code at dockerClient.logs() can be removed (see https://github.com/gesellix/docker-client/blob/master/src/main/groovy/de/gesellix/docker/client/DockerClientImpl.groovy#L832).
@gesellix
Copy link
Owner Author

gesellix commented Jul 17, 2021 •
edited
Loading

The docs for the current api version 1.41 now explicitly describe the response headers regarding the encoding and content-type:

logs returned as a stream in response body. For the stream format, see the documentation for the attach endpoint. Note that unlike the attach endpoint, the logs endpoint does not upgrade the connection and does not set Content-Type.

I still wonder why the api has such inconsistent behaviour, but at least it's documented since moby/moby#38819.

gesellix added a commit that referenced this issue Jul 17, 2021
@gesellix
Add a multiplexed stream decoder.
cccfced 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 18, 2021
@gesellix
Add a multiplexed stream decoder.
0224337 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 19, 2021
@gesellix
Add a multiplexed stream decoder.
b8733e6 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 19, 2021
@gesellix
Add a multiplexed stream decoder.
b1502df 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 19, 2021
@gesellix
Add a multiplexed stream decoder.
c755d8f 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 20, 2021
@gesellix
Add a multiplexed stream decoder.
1721688 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 20, 2021
@gesellix
Add a multiplexed stream decoder.
8374270 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
@gesellix
Copy link
Owner Author

A possible fix is moby/moby#39812

gesellix added a commit that referenced this issue Jul 21, 2021
@gesellix
Add a multiplexed stream decoder.
53bd6ae 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Jul 21, 2021
@gesellix
Add a multiplexed stream decoder.
aa7043d 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 6, 2021
@gesellix
Add a multiplexed stream decoder.
7244c2f 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 7, 2021
@gesellix
Add a multiplexed stream decoder.
1b2fdcd 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 9, 2021
@gesellix
Add a multiplexed stream decoder.
3f6ef83 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 9, 2021
@gesellix
Add a multiplexed stream decoder.
7e012ad 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 17, 2021
@gesellix
Add a multiplexed stream decoder.
d47dbdf 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 21, 2021
@gesellix
Add a multiplexed stream decoder.
57796a8 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 22, 2021
@gesellix
Add a multiplexed stream decoder.
b4928a8 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 22, 2021
@gesellix
Add a multiplexed stream decoder.
870b1ea 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 26, 2021
@gesellix
Add a multiplexed stream decoder.
ce6d4b6 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 26, 2021
@gesellix
Add a multiplexed stream decoder.
0e2832b 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 27, 2021
@gesellix
Add a multiplexed stream decoder.
ee1096e 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 27, 2021
@gesellix
Add a multiplexed stream decoder.
bb5f468 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Aug 31, 2021
@gesellix
Add a multiplexed stream decoder.
deaea53 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 24, 2021
@gesellix
Add a multiplexed stream decoder.
cfe289b 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 26, 2021
@gesellix
Add a multiplexed stream decoder.
69f3ea3 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 26, 2021
@gesellix
Add a multiplexed stream decoder.
7ee9b3a 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 26, 2021
@gesellix
Add a multiplexed stream decoder.
a8258a2 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 28, 2021
@gesellix
Add a multiplexed stream decoder.
0389475 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 29, 2021
@gesellix
Add a multiplexed stream decoder.
7d053d7 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Sep 29, 2021
@gesellix
Add a multiplexed stream decoder.
b0663ea 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Oct 3, 2021
@gesellix
Add a multiplexed stream decoder.
3302402 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Oct 3, 2021
@gesellix
Add a multiplexed stream decoder.
64e52fe 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
gesellix added a commit that referenced this issue Nov 5, 2021
@gesellix
Add a multiplexed stream decoder.
b5a9979 
See https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach for the stream format documentation.

Handling the .../logs endpoints would work without the custom interceptor, when the response content-type would be set correctly :-/
See #21 for details.
This was referenced May 7, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gesellix