Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the multi-arch manifest creation more modular #22

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Make the multi-arch manifest creation more modular #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 31 additions & 52 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,88 +8,68 @@ on:
# - published

jobs:
build-publish-containers:
build-publish-linux:
name: Build and Publish Containers
runs-on: ${{ matrix.os }}
strategy:
max-parallel: 3
matrix:
include:
- platform: linux/amd64
os: ubuntu-latest
use-buildx: true
# base: 3.15.4
file: linux/Dockerfile
tag-suffix: -linux-amd64
- platform: linux/arm64/8
os: ubuntu-latest
use-buildx: true
# base: 3.15.4
file: linux/Dockerfile
tag-suffix: -linux-arm64-8
- platform: windows/amd64
# os: windows-latest
os: windows-2022
# Not supported under Windows, see:
# Not supported by buildx, yet ("Error response from daemon: Windows does not support privileged mode")
# Related: https://github.com/docker/buildx/issues/176
# Related: https://github.com/docker/build-push-action/issues/18
use-buildx: false
# base: ltsc2022
file: windows/Dockerfile
tag-suffix: -windows-amd64
runs-on: ubuntu-latest
steps:
- name: Set release version
if: ${{ matrix.use-buildx == true }}
run: |
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" >> $GITHUB_ENV
- name: Set release version
if: ${{ matrix.use-buildx == false }}
run: |
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" | Out-File -FilePath $env:GITHUB_ENV -Append
- name: Print release version
run: |
echo ${{ env.RELEASE_VERSION }}
- name: Checkout
uses: actions/checkout@v3
- name: Set up QEMU
if: ${{ matrix.use-buildx == true }}
uses: docker/setup-qemu-action@v2
- name: Set up Docker Buildx
if: ${{ matrix.use-buildx == true }}
uses: docker/setup-buildx-action@v2
- name: Login to DockerHub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Build and Push image
if: ${{ matrix.use-buildx == true }}
uses: docker/build-push-action@v3
with:
context: .
file: ${{ matrix.file }}
file: linux/Dockerfile
# build-args: |
# BASE=${{ matrix.base }}
platforms: ${{ matrix.platform }}
platforms: linux/amd64,linux/arm64/8
push: true
tags: gesellix/npipe:${{ env.RELEASE_VERSION }}${{ matrix.tag-suffix }}
tags: gesellix/npipe:${{ env.RELEASE_VERSION }}-linux
build-publish-windows:
name: Build and Publish Containers
runs-on: windows-2022
steps:
- name: Set release version
run: |
echo "RELEASE_VERSION=$(echo '${{ github.event.release.tag_name }}' | sed -e s/^v//)" | Out-File -FilePath $env:GITHUB_ENV -Append
- name: Print release version
run: |
echo ${{ env.RELEASE_VERSION }}
- name: Checkout
uses: actions/checkout@v3
- name: Login to DockerHub
uses: docker/login-action@v2
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}
- name: Docker Build
if: ${{ matrix.use-buildx == false }}
run: |
docker build -f ${{ matrix.file }} -t gesellix/npipe:${{ env.RELEASE_VERSION }}${{ matrix.tag-suffix }} .
# docker build -f ${{ matrix.file }} --build-arg BASE=${{ matrix.base }} -t gesellix/npipe:${{ env.RELEASE_VERSION }}${{ matrix.tag-suffix }} .
docker build -f windows/Dockerfile -t gesellix/npipe:${{ env.RELEASE_VERSION }}-windows .
# docker build -f windows/Dockerfile --build-arg BASE=${{ matrix.base }} -t gesellix/npipe:${{ env.RELEASE_VERSION }}-windows .
- name: Docker Push
if: ${{ matrix.use-buildx == false }}
run: |
docker push gesellix/npipe:${{ env.RELEASE_VERSION }}${{ matrix.tag-suffix }}
# from:
# https://github.com/phillipsj/pstools/blob/main/.github/workflows/publish.yaml
# https://www.phillipsj.net/posts/building-windows-and-linux-containers-with-github-actions/
docker push gesellix/npipe:${{ env.RELEASE_VERSION }}-windows

publish-manifest:
name: Publish Manifest
runs-on: ubuntu-latest
needs: build-publish-containers
needs:
- build-publish-linux
- build-publish-windows
steps:
- name: Set release version
run: |
Expand All @@ -104,9 +84,8 @@ jobs:
- name: Docker Manifest
run: |
docker manifest create gesellix/npipe:${{ env.RELEASE_VERSION }} \
--amend gesellix/npipe:${{ env.RELEASE_VERSION }}-linux-amd64 \
--amend gesellix/npipe:${{ env.RELEASE_VERSION }}-linux-arm64-8 \
--amend gesellix/npipe:${{ env.RELEASE_VERSION }}-windows-amd64
--amend gesellix/npipe:${{ env.RELEASE_VERSION }}-linux \
--amend gesellix/npipe:${{ env.RELEASE_VERSION }}-windows
# - name: Docker Annotate
# run: |
# docker manifest annotate --os windows --arch amd64 \
Expand Down