Link to a binary that wont get yanked. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request njr
Changed imagemagick version to one that currently is downloadable
…yntax. Add debugging instructions
maximusdominus
force-pushed
the
master
branch
from
4f06ea7 to
6f1d55f
Compare
ImageMagick binaries need to be able to find their configuration files, and in some cases they need extra help in doing so. By setting the `MAGICK_CONFIGURE_PATH` to the installed location of those files, we can ensure that the binaries know where to look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the binary every few days to try and keep pace with ImageMagick releases is the wrong approach, because it produces an unstable repository and is not suitable for production. I've linked to an older binary that will not get removed from ImageMagick's releases folder. Also included are updates to Heroku's buildpack syntax in the readme.
When merging, you'll want to update the hash in the README to link to a
gestevescommit.