Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing enhancements #2 #4

Merged
merged 12 commits into from
Sep 29, 2023
Merged

Testing enhancements #2 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
e363a89
gradle update and testing enhancements
vokod Sep 25, 2023
550bfc6
testing enhancements
vokod Sep 25, 2023
08e908f
review remarks
vokod Sep 26, 2023
e2d6b4c
fix mistakes
vokod Sep 26, 2023
daa65fc
Merge branch 'main' into feature/testing_enhancements
vokod Sep 26, 2023
4557114
fix mistakes
vokod Sep 26, 2023
5ebe338
revert dispatcher change
vokod Sep 26, 2023
be43294
fix context
vokod Sep 26, 2023
2c245f8
fix dispatcher
vokod Sep 26, 2023
a033807
trying to fix kotest
vokod Sep 27, 2023
c6a48cf
trying to fix kotest again
vokod Sep 27, 2023
bfdec9b
fix unit tests
vokod Sep 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions core/src/main/kotlin/com/bridge/ouroboros/compose/ExecutableEffect.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,20 +3,16 @@ package com.bridge.ouroboros.compose
import kotlinx.coroutines.CoroutineDispatcher
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.SupervisorJob
import kotlinx.coroutines.launch
import kotlin.coroutines.CoroutineContext

abstract class ExecutableEffect<EVENT, EFFECT_STATE> : CoroutineScope {

private val job = SupervisorJob()

private var currentContext: CoroutineContext? = null

override val coroutineContext: CoroutineContext
get() {
checkNotNull(currentContext) { "coroutineContext must be attached before invoking perform" }
return job + defaultDispatcher
}
get() = currentContext?.let { it + defaultDispatcher }
?: error("coroutineContext must be attached before invoking perform")

abstract fun EFFECT_STATE.perform(emit: EventConsumer<EVENT>)

Expand All @@ -35,7 +31,7 @@ abstract class ExecutableEffect<EVENT, EFFECT_STATE> : CoroutineScope {

companion object {
@Volatile
private var defaultDispatcher: CoroutineDispatcher = Dispatchers.Main
private var defaultDispatcher: CoroutineDispatcher = Dispatchers.Default

fun setDefaultDispatcher(dispatcher: CoroutineDispatcher) {
defaultDispatcher = dispatcher
Expand Down
5 changes: 4 additions & 1 deletion example-app/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,10 @@ dependencies {
implementation Libs.material

testImplementation Libs.junit
testImplementation Libs.Kotest.assertions
testImplementation (Libs.Kotest.assertions){
exclude group: 'org.jetbrains.kotlin'
}

testImplementation Libs.MockK.library
testImplementation project(':test')

Expand Down
4 changes: 3 additions & 1 deletion test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ android {

dependencies {
api project(':core')
implementation 'io.kotest:kotest-assertions-core:5.6.0'
implementation (Libs.Kotest.assertions){
exclude group: 'org.jetbrains.kotlin'
}
}

afterEvaluate {
Expand Down