fix: Ignore missing order id when rejecting a rollover offer #2557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
reviewed
May 22, 2024
|
I'm not sure I understand this fix. |
bonomat
approved these changes
May 22, 2024
In case of a rollover we do not have an order id or and order in filling. As a result this logic failed when trying to reject a rollover offer. The solution is still hacky as with the correct context information we shouldn't even try to set the order to failed, but that context is missing when we are reconnecting in the `on_connect` function and finding a dlc channel in state `RenewOffered`.
Otherwise the position is stuck in `Rollover` and won't get recovered.
holzeis
force-pushed
the
fix/handle-pending-rollover-offer
branch
from
c6b5237 to
ffd6b56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of a rollover we do not have an order id or and order in filling. As a result this logic failed when trying to reject a rollover offer.
The solution is still hacky as with the correct context information we shouldn't even try to set the order to failed, but that context is missing when we are reconnecting in the
on_connectfunction and finding a dlc channel in stateRenewOffered.fixes #2554