Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mobile): add Vietnamese support for dates #383

Merged
merged 1 commit into from
Sep 28, 2024
Merged

feat(mobile): add Vietnamese support for dates #383

merged 1 commit into from
Sep 28, 2024

Conversation

lamvh
Copy link
Collaborator

@lamvh lamvh commented Sep 24, 2024 •
edited
Loading

Issue: #283

@lamvh Graphite App
Copy link
Collaborator Author

lamvh commented Sep 24, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @lamvh and the rest of your teammates on Graphite Graphite

@lamvh lamvh marked this pull request as ready for review September 24, 2024 06:50
@graphite-app graphite-app bot requested review from duongdev and bkdev98 September 24, 2024 06:51
@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 24, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (09/24/24)

3 reviewers were added to this PR based on Dustin Do's automation.

duongdev
duongdev reviewed Sep 24, 2024
View reviewed changes
Copy link
Member

@duongdev duongdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only en and vi are supported right? Did you test other languages fallback?

@duongdev duongdev changed the title fix(mobile): #283 localize dates when app language is changed feat(mobile): add Vietnamese support for dates Sep 24, 2024
@lamvh lamvh mentioned this pull request Sep 26, 2024
Merged
@duongdev Graphite App
Copy link
Member

duongdev commented Sep 28, 2024 •
edited
Loading

Merge activity

  • Sep 27, 11:31 PM EDT: @duongdev started a stack merge that includes this pull request via Graphite.
  • Sep 27, 11:31 PM EDT: @duongdev merged this pull request with Graphite.

@duongdev duongdev merged commit 5e6d2ae into main Sep 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duongdev duongdev duongdev approved these changes

@bkdev98 bkdev98 Awaiting requested review from bkdev98

Assignees
No one assigned
Labels
None yet
Projects
6pm
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lamvh @duongdev