Missing functions in JS appmaps

[ahtrotta]

I mapped cli in appmap-js and got some maps, but I noticed that many of them are missing functions. For example, the map from this test case is missing pruneWithFilter and displayMessage.

For context, here is my appmap.yml file (this file is in packages/cli) that was generated by the JS agent:

packages:
  - regexp: ^../
    enabled: true 
  - regexp: (^|/)node_modules/
    enabled: true 
  - regexp: ""
    enabled: true
default-package:
  enabled: false
exclude:
  - combinator: and
    name: ^\[anonymous\]$
    every-label: ^\b$
    excluded: true
    recursive: false
log:
  level: info
ordering: chronological
serialization:
  impure-printing: false
  impure-constructor-naming: false
  impure-array-inspection: false
  impure-error-inspection: false
  impure-hash-inspection: false
appmap-dir: tmp

[ahtrotta]

Here's another example from this test. The map has locateAppMapDir, but then it doesn't capture the function call to appmapDirFromConfig from within locateApMapDir.

[lachrist]

@ahtrotta The agent works by instrumenting function declarations not function applications. As you can imagine, changing that is big leap. Are the the functions pruneWithFilter and displayMessage declared in whitelisted file?

[kgilpin]

Why isn't the function call to appmapDirFromConfig from within locateApMapDir recorded?

…

On Wed, Apr 26, 2023 at 4:42 PM Laurent Christophe ***@***.***> wrote: @ahtrotta <https://github.com/ahtrotta> The agent works by instrumenting function declarations not function applications. As you can imagine, changing that is big leap. Are the the functions pruneWithFilter and displayMessage declared in whitelisted file? — Reply to this email directly, view it on GitHub <#210 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC63HS6OOVMSYLZ4NLUTXDGCBRANCNFSM6AAAAAAWRYDQ2A> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[lachrist]

If it was not excluded, it is a bug.

[kgilpin]

Why? Can someone please explain in more than one line.

…

On Fri, Apr 28, 2023 at 3:18 PM Laurent Christophe ***@***.***> wrote: If it was not excluded, it is a bug. — Reply to this email directly, view it on GitHub <#210 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAVC64SWQE6JPRJRXQT4JLXDQJZDANCNFSM6AAAAAAWRYDQ2A> . You are receiving this because you commented.Message ID: ***@***.***>