Record tsc compiled code

[dustinbyrne]

This fixes an issue found while trying to record @appland/scanner and adds some additional test cases.

Resolves #173

[lachrist]

Hi @dustinbyrne thanks for digging into this. The trace post-processing is rather complex and I remember that the pipeline of modules relies on assertion made earlier. So I don't think you can simply silence assertions. However I agree that producing something is better than panicking. I think the best way to proceed is to try the complex event re-ordering. If it fails (via assertions) we can try a simpler post-processing where we simply make sure the produced appmap is valid but we do not make any guarantee on the order of events.

[dustinbyrne]

There are two items blocking this:

First, all AppMaps recorded from Jest tests are empty. This may be related to #172 where a transform is being applied. After all, this is using ts-jest. It may also be a configuration issue, but process recordings are functional. TBD.

Lastly, Jest command line arguments are not being transformed safely, and I've yet to come up with a strategy which doesn't involve mirroring Jests command line logic. Here are some examples where it breaks down.

$ npx jest authn

Would result in the following transformed command:

$ npx jest --runInBand --setupFilesAfterEnv /module/path.js authn

This is incorrect because authn will be read in as a setup file instead of a test path pattern. To retain the same behavior, the command would be one of the following:

$ npx jest --runInBand --setupFilesAfterEnv /module/path.js -- authn
$ npx jest --runInBand --setupFilesAfterEnv /module/path.js --testPathPattern authn

This is complicated by the fact that the user may add other options to the command line:

$ npx jest --detectOpenHandles authn

Would need to resolve to one of the following:

$ npx jest --runInBand --setupFilesAfterEnv /module/path.js --detectOpenHandles -- authn
$ npx jest --runInBand --setupFilesAfterEnv /module/path.js --detectOpenHandles --testPathPattern authn

This is again complicated by the fact that we don't know if authn is a test path pattern or an argument of detectOpenHandles. Any tokens remaining after parsing options are treated as test path patterns. Ideally, we would not want to re-implement this logic as it's likely to change (and probably already has across versions).

[lachrist]

Ah I did not expect --setupFilesAfterEnv to eats all the non-dashed argument after it. The fix with the transformer will require to parse both the configuration file and the arguments. I will make sure I take this into account.

[dustinbyrne]

The transformer fix is in the works and I've opened a separate issue for the Jest command line arguments (#179).

I don't think it's worth waiting for the outstanding items before shipping these.

ups

[lachrist]

Thanks for the work. Some information on the failures you had related the two last commits would help. Cheers!

[lachrist]

I still have an issue with your removal of the assertion. I made a fix in #185. You could leave the test but it will need to be updated because the qualified name of a root function is with the filename.

[dustinbyrne]

I've rebased off the branch in #185 and dropped the commit to pass the assertion. The test seems unnecessary without providing an undefined or null parent.

[lachrist]

Brazinga

[appland-release]

🎉 This PR is included in version 13.1.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀