Update name of remote recording before allowing the AppMap indexer to index it #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap pull request analysis
|
jansorg
force-pushed
the
jansorg/appmap-naming
branch
from
307b724 to
182e840
Compare
ahtrotta
previously approved these changes
Oct 19, 2023
|
Can you look into why the Travis build is failing? |
|
@ahtrotta https://github.com/getappmap/appmap-intellij-plugin/actions/runs/6560959318/job/17819660900#step:7:488, which is a bug in the AppMap agent: getappmap/appmap-java#229 |
The Travis build is failing, though: https://app.travis-ci.com/github/getappmap/appmap-intellij-plugin/builds/266673696 |
jansorg
force-pushed
the
jansorg/appmap-naming
branch
from
182e840 to
435414f
Compare
ahtrotta
approved these changes
Oct 24, 2023
|
🎉 This PR is included in version 0.52.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #477
This streams the AppMap JSON of the remote recording to a temporary file, then updates the
metadata.nameproperty of this file and then moves it to the final file, which has a.appmap.jsonextension.This PR re-enables test
appland.remote.DefaultRemoteRecordingServiceTestto cover the remote recording implementation. Previously, it was disabled due to incompatibility with an active AppMap agent.