Restart AppMap process when it terminates unexpectedly #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AppMap runtime code review
⭐ New AppMaps[junit] Default command line service indexer process restart from [junit] Default command line service scanner process restart from |
jansorg
force-pushed
the
jansorg/cli-termination-handling
branch
from
37c29f8 to
67fa2dc
Compare
jansorg
changed the title
jansorg
force-pushed
the
jansorg/cli-termination-handling
branch
2 times, most recently
from
94c7727 to
cd52710
Compare
jansorg
force-pushed
the
jansorg/cli-termination-handling
branch
3 times, most recently
from
81592ad to
e467b10
Compare
jansorg
force-pushed
the
jansorg/cli-termination-handling
branch
from
e467b10 to
b44510a
Compare
ahtrotta
approved these changes
Nov 30, 2023
|
🎉 This PR is included in version 0.54.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #411
This PR implements restart of AppMap CLI processes.
Initially, when processes are launched for an AppMap-enabled directory, both indexer and scanner processes are started.
Now, when one of the processes terminates unexpectedly, this process is restarted after a delay. The initial delay is
5s, the next next5s*1.5=7.25sand the next7.25s*1.5=10.9sand after the third unexpected termination no further restart is attempted.This PR adds a tests to verify the restart.