Remove usage of internal API #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A non-dumb-aware StartupActivity is launched on the EDT.
AppMap runtime code review
|
ahtrotta
approved these changes
Nov 15, 2023
|
🎉 This PR is included in version 0.53.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #492
Replaces usage of all
@InternalAPI with an alternative. We're not using internal API anymore.This PR also drops use of API which was deprecated in 2021.3, which is the earliest supported version.
The changes to drop internal API from AppMapFilesIterator have the side-effect that we're not supporting symlinked appmap directories anymore. I don't think that it's used at all and
build/appmapandtarget/appmapare never symlinks by default.