Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve webview build and code sharing #530

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Conversation

jansorg
Copy link
Collaborator

@jansorg jansorg commented Jan 15, 2024

  • To remove deduplication, common code messagePublisher.js and vsCodeBridge.js is now shared between our different webviews
  • Updates all webpack configs to avoid Vue development mode in our production builds and to fix local problems with the invocation of yarn
  • Updates all AppMap components of all webviews to the latest versions

@jansorg jansorg changed the title chore: fix production build webviews to avoid vuejs development mode Avoid vuejs development mode, update to latest AppMap components Jan 15, 2024
Copy link

AppMap runtime code review

Summary Status
Failed tests ✅ All tests passed
API changes 0️⃣ No API changes
Security flaws ✅ None detected
Performance problems ✅ None detected
Code anti-patterns ✅ None detected
New AppMaps 0️⃣ No new AppMaps

@jansorg jansorg changed the title Avoid vuejs development mode, update to latest AppMap components Improve webview build and code sharing Jan 15, 2024
@jansorg jansorg requested a review from ahtrotta January 15, 2024 13:37
@ahtrotta ahtrotta self-requested a review January 19, 2024 17:47
ahtrotta
ahtrotta previously approved these changes Jan 19, 2024
@ahtrotta ahtrotta dismissed their stale review January 19, 2024 17:48

Investigating packageManager field in package.json.

@jansorg
Copy link
Collaborator Author

jansorg commented Jan 23, 2024

Thank you for the Yarn fix, @ahtrotta! It's working well now.

@jansorg jansorg requested a review from ahtrotta January 23, 2024 11:20

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…AppMap components
…x webpack build
@ahtrotta ahtrotta force-pushed the jansorg/webview-vuejs-mode branch from b9f5592 to 6b85fa7 Compare January 23, 2024 13:57
@ahtrotta ahtrotta merged commit 37894d2 into develop Jan 23, 2024
6 checks passed
@ahtrotta ahtrotta deleted the jansorg/webview-vuejs-mode branch January 23, 2024 15:00
@appland-release
Copy link
Contributor

🎉 This PR is included in version 0.55.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants